Skip to content

Commit 1329d0a

Browse files
committed
fix: update documentation of baseline workflow
1 parent 136ffc2 commit 1329d0a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/update_regression_baseline.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,11 @@ jobs:
8484
fi
8585
NEW_BASELINE=1 pytest -m regression
8686
87-
# The following will not work if the PR is initiated from a fork. In this case
88-
# we create a new PR to update the baseline (see below).
89-
# Only run if baseline generation succeeded
87+
# Pushing to the PR branch does not work if the PR is initiated from a fork. This is
88+
# because the GITHUB_TOKEN has read-only access by default for workflows triggered by
89+
# fork PRs. Hence we have to create a new PR to update the baseline (see below).
9090
- name: Commit and push to PR branch (non-fork)
91+
# Only run if baseline generation succeeded
9192
if: success() && steps.update-baseline.outcome == 'success' && !fromJson(steps.check-fork.outputs.result)
9293
run: |
9394
git add -f tests/regression_test_baselines.json # since it's in .gitignore

0 commit comments

Comments
 (0)