Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of ml-dtypes 0.4.0 is failing on Power #183

Open
sandeepgupta12 opened this issue Sep 11, 2024 · 4 comments
Open

Build of ml-dtypes 0.4.0 is failing on Power #183

sandeepgupta12 opened this issue Sep 11, 2024 · 4 comments

Comments

@sandeepgupta12
Copy link

We are encountering a build failure with ml-dtypes version 0.4.0 on Power architecture because it requires numpy 2.0.0rc1 for a successful build. Below is the error log we are seeing during the installation via pip:
----------------------------------------------Error Logs-----------------------------------------------------------
pip install ml_dtypes

Collecting ml_dtypes
Using cached ml_dtypes-0.4.0.tar.gz (692 kB)
Installing build dependencies ... error
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> [3 lines of output]
ERROR: Ignored the following versions that require a different python version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11
ERROR: Could not find a version that satisfies the requirement numpy==2.0.0rc1 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 1.13.3, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0, 1.21.1, 1.22.0, 1.22.1, 1.22.2, 1.22.3, 1.22.4, 1.23.0, 1.23.1, 1.23.2, 1.23.3, 1.23.4, 1.23.5, 1.24.0, 1.24.1, 1.24.2, 1.24.3, 1.24.4, 1.25.0, 1.25.1, 1.25.2, 1.26.0, 1.26.1, 1.26.2, 1.26.3, 1.26.4, 2.0.0, 2.0.1, 2.0.2, 2.1.0rc1, 2.1.0, 2.1.1)
ERROR: No matching distribution found for numpy==2.0.0rc1
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

We are aware that this issue has already been fixed in the main branch. Is it possible to either:
1. Retag/build version 0.4.0 with the required fix?
2. Release a new version that includes this fix?

Additionally, we noticed that there is no wheel file for ml-dtypes available on PyPI for the Power architecture. Could the build process be enabled for Power? If this is feasible, we are happy to contribute a PR to assist with the effort.

@npanpaliya
Copy link

@jakevdp - Could you please let us know if we can add Power support to ml-dtypes? I see you've commented in another issue that you're going to tag a new release soon, it would be great if we could get Power wheel file as well on PyPi in that release. We are happy to contribute the changes needed.

@hawkinsp
Copy link
Collaborator

We're about to make a new release that pins NumPy 2.0 (not the -rc1) release as a build dependency. I think that will resolve this problem.

I don't think we'd have an objection to shipping Power wheels, if that's helpful, and you can contribute a PR to do such a build in a github action. In general, we're trying to be very compatible with everything for this package, since it's small and useful for many people.

@npanpaliya
Copy link

Thank you @hawkinsp . We will raise a PR to add Power wheel.

@sandeepgupta12
Copy link
Author

Hi @hawkinsp, we've opened PR #230 to add support for the Power wheel. Could you please review it and proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants