Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated selector in language-blade\styles\language-blade.atom-text-editor.less #60

Closed
Ingramz opened this issue Oct 24, 2016 · 2 comments
Assignees
Labels
atom-core The issue is dependent on Atom project or any of the first-party packages. enhancement Request for a new feature.

Comments

@Ingramz
Copy link
Collaborator

Ingramz commented Oct 24, 2016

In language-blade\styles\language-blade.atom-text-editor.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • .support.function.construct.end.blade .source.php => .syntax--support.syntax--function.syntax--construct.syntax--end.syntax--blade .syntax--source.syntax--php

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.


I'm gonna deal with it eventually, however I believe prepending all syntax classes with syntax-- is a bit dumb. If there is no other way around this, then I'll do the necessary changes.

@Ingramz Ingramz added enhancement Request for a new feature. atom-core The issue is dependent on Atom project or any of the first-party packages. labels Oct 24, 2016
@Ingramz Ingramz self-assigned this Oct 24, 2016
@Ingramz
Copy link
Collaborator Author

Ingramz commented Nov 22, 2016

Seems like there is no way of protesting this. Will be changed in time for 1.13.0.

@Ingramz
Copy link
Collaborator Author

Ingramz commented Dec 7, 2016

Fixed by 14104c1

@Ingramz Ingramz closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atom-core The issue is dependent on Atom project or any of the first-party packages. enhancement Request for a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant