Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Error Thrown If File Path Is Invalid For df.readCSV? #456

Closed
guekling opened this issue May 20, 2022 · 2 comments
Closed

No Error Thrown If File Path Is Invalid For df.readCSV? #456

guekling opened this issue May 20, 2022 · 2 comments
Assignees

Comments

@guekling
Copy link

guekling commented May 20, 2022

Describe the bug
When an invalid filepath is passed into df.readCSV, no errors are thrown and the request is never resolved. Are we supposed to check for validity of filepath ourselves before passing it into the function?

To Reproduce
Use the following code:

import * as dfd from "danfojs-node";

dfd.readCSV("invalid-filepath.csv")
  .then((df) => {
    // some code
  })
  .catch((error) => {
    console.log(error)
  })

Expected behavior
Should throw an error.

Additional context
Using danfojs-node v1.1.1

@risenW risenW assigned risenW and unassigned steveoni Sep 25, 2022
@risenW
Copy link
Member

risenW commented Sep 25, 2022

Fixed in #503

@risenW risenW closed this as completed Sep 25, 2022
@ghost
Copy link

ghost commented Nov 23, 2023

I encounter the same issue using "danfojs" v1.1.2 in Angular. Has this been fixed for node-only or browser as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants