Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

[PORT 2.2.8]JAVASERVERFACES-3531 didn't correct all uses of getExternalContext().isSecure() #4104

Closed
javaserverfaces opened this issue Feb 4, 2016 · 5 comments
Closed

[PORT 2.2.8]JAVASERVERFACES-3531 didn't correct all uses of getExternalContext().isSecure() #4104

javaserverfaces opened this issue Feb 4, 2016 · 5 comments
Assignees
@xinyuan-zhang
Labels
Component: flash ERR: Assignee Priority: Major Type: Bug

Comments

@javaserverfaces
Copy link
Collaborator

It seems that the fix applied in #3535 didn't correct all uses of getExternalContext().isSecure(). In particular, it's still called from elsewhere in ELFlash#setCookie [1].

Please fix the bug, because a Red Hat customer needs this issue to be resolved.

[1] https://github.com/jboss/mojarra/blob/8111d0950fa9a1bb2e48934bae76a466f474b552/jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java#L1002

Affected Versions

[2.1.29]
@javaserverfaces
Copy link
Collaborator Author

Reported by ivassile

@javaserverfaces
Copy link
Collaborator Author

Issue-Links:
clones
JAVASERVERFACES-4074

@javaserverfaces
Copy link
Collaborator Author

Was assigned to ren.zhijun.oracle

@javaserverfaces
Copy link
Collaborator Author

This issue was imported from java.net JIRA JAVASERVERFACES-4100

xinyuan-zhang referenced this issue Jun 15, 2017
@xinyuan-zhang
[port 2.2.x] JAVASERVERFACES-3531 didn't correct all uses of getExter…
de71ab8 
…nalContext().isSecure()

https://github.com/javaserverfaces/mojarra/issues/4104

modified:   jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java
@xinyuan-zhang xinyuan-zhang mentioned this issue Jun 15, 2017
Closed
xinyuan-zhang referenced this issue Jun 15, 2017
@xinyuan-zhang
[port 2.2.8] JAVASERVERFACES-3531 didn't correct all uses of getExter…
df2adde 
…nalContext().isSecure()

https://github.com/javaserverfaces/mojarra/issues/4104

modified:   jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java
@xinyuan-zhang
Copy link
Contributor

applied to 2.2.8: df2adde

[port 2.2.8] JAVASERVERFACES-3531 didn't correct all uses of getExternalContext().isSecure()
https://github.com/javaserverfaces/mojarra/issues/4104

modified:   jsf-ri/src/main/java/com/sun/faces/context/flash/ELFlash.java

This was referenced Apr 18, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xinyuan-zhang xinyuan-zhang

Labels
Component: flash ERR: Assignee Priority: Major Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javaserverfaces @glassfishrobot @xinyuan-zhang