Fix build with mingw-64 on windows #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
force-pushed
the
fix_gcc_build
branch
from
9c72d7d
to
f31655f
Compare
mingw used to directly use the msvcrt implementation of swprintf which does does not match the ANSI version. This was fixed in mingw-w64 and so this special case has to be removed.
matthiasblaesing
force-pushed
the
fix_gcc_build
branch
from
1d9efa6
to
b09171c
Compare
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…va-native-access#732) Motivation: The ByteBuf that is passed into the `writeToken(...)` method should use `BIG_ENDIAN` while at the moment it might use `LITTLE_ENDIAN`. Modifications: * Ensures that all buffers passed to the `QuicTokenHandler` are now big endian * Expose max connection it via static field in Quic class. Result: Fixes java-native-access#731. --------- Co-authored-by: Norman Maurer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mingw used to directly use the msvcrt implementation of swprintf which
does does not match the ANSI version. This was fixed in mingw-64 and
so this special case has to be removed.