Skip to content

Commit bd65664

Browse files
committed
Merge remote-tracking branch 'elastic/master' into packaging-script-one-liners
* elastic/master: [TEST] Enable DEBUG logging on testAutoQueueSizingWithMax [ML] Don't install empty ML metadata on startup (elastic#30751) Add assertion on removing copy_settings (elastic#30748) bump lucene version for 6_3_0 [DOCS] Mark painless execute api as experimental (elastic#30710) disable annotation processor for docs (elastic#30610) Add more script contexts (elastic#30721) Fix default shards count in create index docs (elastic#30747)
2 parents 0bb5cfc + 42b0b45 commit bd65664

File tree

47 files changed

+132
-265
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+132
-265
lines changed

buildSrc/src/main/groovy/org/elasticsearch/gradle/test/StandaloneTestPlugin.groovy

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import org.elasticsearch.gradle.BuildPlugin
2424
import org.gradle.api.Plugin
2525
import org.gradle.api.Project
2626
import org.gradle.api.plugins.JavaBasePlugin
27+
import org.gradle.api.tasks.compile.JavaCompile
2728

2829
/**
2930
* Configures the build to compile against Elasticsearch's test framework and
@@ -49,5 +50,12 @@ public class StandaloneTestPlugin implements Plugin<Project> {
4950
test.testClassesDir project.sourceSets.test.output.classesDir
5051
test.mustRunAfter(project.precommit)
5152
project.check.dependsOn(test)
53+
54+
project.tasks.withType(JavaCompile) {
55+
// This will be the default in Gradle 5.0
56+
if (options.compilerArgs.contains("-processor") == false) {
57+
options.compilerArgs << '-proc:none'
58+
}
59+
}
5260
}
5361
}

docs/painless/painless-execute-script.asciidoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
[[painless-execute-api]]
22
=== Painless execute API
33

4+
experimental[The painless execute api is new and the request / response format may change in a breaking way in the future]
5+
46
The Painless execute API allows an arbitrary script to be executed and a result to be returned.
57

68
[[painless-execute-api-parameters]]

docs/reference/indices/create-index.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ PUT twitter
2525
}
2626
--------------------------------------------------
2727
// CONSOLE
28-
<1> Default for `number_of_shards` is 5
28+
<1> Default for `number_of_shards` is 1
2929
<2> Default for `number_of_replicas` is 1 (ie one replica for each primary shard)
3030

3131
The above second curl example shows how an index called `twitter` can be

plugins/examples/script-expert-scoring/src/main/java/org/elasticsearch/example/expertscript/ExpertScriptPlugin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public String getType() {
5454

5555
@Override
5656
public <T> T compile(String scriptName, String scriptSource, ScriptContext<T> context, Map<String, String> params) {
57-
if (context.equals(SearchScript.CONTEXT) == false) {
57+
if (context.equals(SearchScript.SCRIPT_SCORE_CONTEXT) == false) {
5858
throw new IllegalArgumentException(getType() + " scripts cannot be used for context [" + context.name + "]");
5959
}
6060
// we use the script "source" as the script identifier

server/src/main/java/org/elasticsearch/Version.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public class Version implements Comparable<Version>, ToXContentFragment {
169169
public static final int V_6_2_5_ID = 6020599;
170170
public static final Version V_6_2_5 = new Version(V_6_2_5_ID, LUCENE_7_2_1);
171171
public static final int V_6_3_0_ID = 6030099;
172-
public static final Version V_6_3_0 = new Version(V_6_3_0_ID, org.apache.lucene.util.Version.LUCENE_7_3_0);
172+
public static final Version V_6_3_0 = new Version(V_6_3_0_ID, org.apache.lucene.util.Version.LUCENE_7_3_1);
173173
public static final int V_6_4_0_ID = 6040099;
174174
public static final Version V_6_4_0 = new Version(V_6_4_0_ID, org.apache.lucene.util.Version.LUCENE_7_4_0);
175175
public static final int V_7_0_0_alpha1_ID = 7000001;

server/src/main/java/org/elasticsearch/index/query/TermsSetQueryBuilder.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,8 @@ protected Query doToQuery(QueryShardContext context) throws IOException {
249249
IndexNumericFieldData fieldData = context.getForField(msmFieldType);
250250
longValuesSource = new FieldValuesSource(fieldData);
251251
} else if (minimumShouldMatchScript != null) {
252-
SearchScript.Factory factory = context.getScriptService().compile(minimumShouldMatchScript, SearchScript.CONTEXT);
252+
SearchScript.Factory factory = context.getScriptService().compile(minimumShouldMatchScript,
253+
SearchScript.TERMS_SET_QUERY_CONTEXT);
253254
Map<String, Object> params = new HashMap<>();
254255
params.putAll(minimumShouldMatchScript.getParams());
255256
params.put("num_terms", queries.size());

server/src/main/java/org/elasticsearch/index/query/functionscore/ScriptScoreFunctionBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ protected int doHashCode() {
9292
@Override
9393
protected ScoreFunction doToFunction(QueryShardContext context) {
9494
try {
95-
SearchScript.Factory factory = context.getScriptService().compile(script, SearchScript.CONTEXT);
95+
SearchScript.Factory factory = context.getScriptService().compile(script, SearchScript.SCRIPT_SCORE_CONTEXT);
9696
SearchScript.LeafFactory searchScript = factory.newFactory(script.getParams(), context.lookup());
9797
return new ScriptScoreFunction(script, searchScript);
9898
} catch (Exception e) {

server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestResizeHandler.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
package org.elasticsearch.rest.action.admin.indices;
2121

22+
import org.elasticsearch.Version;
2223
import org.elasticsearch.action.admin.indices.shrink.ResizeRequest;
2324
import org.elasticsearch.action.admin.indices.shrink.ResizeType;
2425
import org.elasticsearch.action.support.ActiveShardCount;
@@ -47,6 +48,8 @@ public abstract class RestResizeHandler extends BaseRestHandler {
4748
public final RestChannelConsumer prepareRequest(final RestRequest request, final NodeClient client) throws IOException {
4849
final ResizeRequest resizeRequest = new ResizeRequest(request.param("target"), request.param("index"));
4950
resizeRequest.setResizeType(getResizeType());
51+
// copy_settings should be removed in Elasticsearch 8.0.0; cf. https://github.com/elastic/elasticsearch/issues/28347
52+
assert Version.CURRENT.major < 8;
5053
final String rawCopySettings = request.param("copy_settings");
5154
final Boolean copySettings;
5255
if (rawCopySettings == null) {

server/src/main/java/org/elasticsearch/script/ScriptModule.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ public class ScriptModule {
4242
CORE_CONTEXTS = Stream.of(
4343
SearchScript.CONTEXT,
4444
SearchScript.AGGS_CONTEXT,
45+
SearchScript.SCRIPT_SCORE_CONTEXT,
46+
SearchScript.SCRIPT_SORT_CONTEXT,
47+
SearchScript.TERMS_SET_QUERY_CONTEXT,
4548
ExecutableScript.CONTEXT,
4649
ExecutableScript.AGGS_CONTEXT,
4750
ExecutableScript.UPDATE_CONTEXT,

server/src/main/java/org/elasticsearch/script/SearchScript.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,12 @@ public interface Factory {
158158

159159
/** The context used to compile {@link SearchScript} factories. */
160160
public static final ScriptContext<Factory> CONTEXT = new ScriptContext<>("search", Factory.class);
161-
// TODO: remove aggs context when it has its own interface
161+
// TODO: remove these contexts when it has its own interface
162162
public static final ScriptContext<Factory> AGGS_CONTEXT = new ScriptContext<>("aggs", Factory.class);
163-
}
163+
// Can return a double. (For ScriptSortType#NUMBER only, for ScriptSortType#STRING normal CONTEXT should be used)
164+
public static final ScriptContext<Factory> SCRIPT_SORT_CONTEXT = new ScriptContext<>("sort", Factory.class);
165+
// Can return a float
166+
public static final ScriptContext<Factory> SCRIPT_SCORE_CONTEXT = new ScriptContext<>("score", Factory.class);
167+
// Can return a long
168+
public static final ScriptContext<Factory> TERMS_SET_QUERY_CONTEXT = new ScriptContext<>("terms_set", Factory.class);
169+
}

0 commit comments

Comments
 (0)