Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package bukuserver #307

Closed
deatharse opened this issue Aug 20, 2018 · 12 comments
Closed

Package bukuserver #307

deatharse opened this issue Aug 20, 2018 · 12 comments

Comments

@deatharse
Copy link

Would like to see either bukuserver included in the Debian package or as its own separate package. It appears to be missing from the Debian packages despite the first entry in the Packages section under What's in? being

A self-hosted http server, bukuserver, that exposes core functionality 
@jarun
Copy link
Owner

jarun commented Aug 20, 2018

@szlin can you please take care of this?

@szlin
Copy link
Collaborator

szlin commented Aug 24, 2018

@jarun As I mentioned before [1], the bukuserver is excluded in Debian package due to DFSG violation.

I suggest to add original javascript into it. If you agree with it, I can squeeze my time to send the patch.

[1] b3437a4#commitcomment-29123671

@jarun
Copy link
Owner

jarun commented Aug 24, 2018

Please raise the PR.

@jarun
Copy link
Owner

jarun commented Aug 29, 2018

@szlin any update on this? I think it will be a good addition to the next release which we will make shortly.

I think the OP is requesting the server files to be added to the generated packages as well. That would need changes to the Makefile.

@jarun
Copy link
Owner

jarun commented Aug 29, 2018

@rachmadaniHaryono can you do the Makefile changes? I am at a loss how to handle this.

@jarun
Copy link
Owner

jarun commented Aug 29, 2018

It would be great if we can have a different Makefile target for bukuserver. The idea is to generate a separate package. PackageCore guys confirmed it's possible to generate multiple packages using separate files.

@szlin
Copy link
Collaborator

szlin commented Aug 29, 2018

@jarun Sorry for the delay, I've sent PR as a short-term solution.
For a long-term solution, I suggest to

  1. separate bukuserver to another git repository which depends on buku.
  2. use chart.js as a dependent library instead of using hard copy one.

Just F.Y.R.

@jarun
Copy link
Owner

jarun commented Aug 29, 2018

Why do you think we need a separate project?

  • We can have distinct targets in Makefile for bukuserver

Isn't it possible to generate 2 different packages with that?

@deatharse
Copy link
Author

If my understanding is correct I think the separate git repo may be to comply with DFSG.

From the https://wiki.debian.org/Javascript/Policy in the linked b3437a4#commitcomment-29123671 if my understanding is correct the separate git repos are to comply with the Debian suggestions where

it's preferable if you name the repository after the source package name (i.e. foo.js.git for foo.js). This isn't a hard requirement though.

implying:

  • bukuserver/static/bukuserver/js/Chart.min.js should be generated at build time for bukuserver.deb (or should that be libjs-bukuserver.deb where bukuserver.deb depends on libjs-bukuserver.deb)

@szlin Is more knowledgeable regarding the Debian guidelines so should be able to provide further information (or correct my interpretation if im wrong :) )

@jarun
Copy link
Owner

jarun commented Aug 29, 2018

This also says:

This isn't a hard requirement though.

I can create an empty project if you guys would want to port the server to it. My knowledge in the web side is lacking and someone should create the Makefile, add packagecore.yaml deps etc. I can link it to travis.

@jarun
Copy link
Owner

jarun commented Aug 30, 2018

@alasdairdc I believe that we do not have the bandwidth to work on this item for now. I have added in the last release notes that bukuserver needs to be installed from PyPi for now.

We need to proceed with the planned release. And this action item may take more time to stabilize things across distros and environments.

I am closing this defect with the note and I will add an item in the ToDo list to handle the packaging of bukuserver. Would you like to take it up?

@jarun jarun closed this as completed Aug 30, 2018
@jarun jarun mentioned this issue Aug 30, 2018
61 tasks
@jarun jarun reopened this Dec 15, 2018
@jarun jarun unassigned szlin Dec 15, 2018
@jarun jarun mentioned this issue Dec 29, 2018
66 tasks
@jarun
Copy link
Owner

jarun commented Apr 24, 2019

Closing this as there is a line item in the ToDo list and this is linked there.

@jarun jarun closed this as completed Apr 24, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants