Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58
In
is_float_none
, theexcept
block is not necessary. It exists to capture aValueError
and returnNone
ifvalue
isNone
or""
. However,value
can never beNone
here becausefloat(None)
throws aTypeError
(see issue #58) which is not caught. As well, ifvalue
is""
then we returnNone
and re-raise the error for any other value.Instead, this conditional can be moved to the beginning of the function. Then, the
float(value)
will continue to raise exceptions for all non-""
values, andNone
will correctly returnNone
.