Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annealing bias #9

Open
zacwellmer opened this issue Oct 20, 2017 · 2 comments
Open

annealing bias #9

zacwellmer opened this issue Oct 20, 2017 · 2 comments

Comments

@zacwellmer
Copy link

I could be wrong but it does not seem that you are annealing the bias with important sampling as suggested in the PER paper(section 3.4).

w_i = (1/N * 1/P(i))^beta

I think you would have to multiply this w_i term with your gradients

@jaromiru
Copy link
Owner

Confirmed.

@zacwellmer
Copy link
Author

I've got a repo where I implemented the importance sampling for ddpg PER. I'm still unsure if it works. But lines 68 - 91 might be useful for you. It's pretty slow, but I still haven't figured out a faster way.

Would be interesting to see how not using importance sampling would effect your results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants