[sync] Bug 1530441 - Enable eslint locally. r=dwalsh

Author: Jason Laster

.eslintrc

@@ -442,6 +442,8 @@
       ],
       "block",
       ["-\\*-(.*)-\\*-", "eslint(.*)", "vim(.*)"]
-    ]
+    ],
+    "consistent-return": "off",
+
   }
 }

assets/dictionary.txt

@@ -208,10 +208,9 @@ asyncStore
 CPG
 TodoMVC
 pseudocode
-TravisCI
-30-60minutes
-myScriptFunction
-Homebrew
 Amit
-Zur
 Zur's
+TravisCI
+Homebrew
+30-60minutes
+myScriptFunction

assets/panel/panel.js

@@ -2,14 +2,10 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { Task } = require("devtools/shared/task");
 const { LocalizationHelper } = require("devtools/shared/l10n");
-const { gDevTools } = require("devtools/client/framework/devtools");
 const {
   gDevToolsBrowser
 } = require("devtools/client/framework/devtools-browser");
-const { TargetFactory } = require("devtools/client/framework/target");
-const { Toolbox } = require("devtools/client/framework/toolbox");
 loader.lazyRequireGetter(
   this,
   "openContentLink",

package.json

@@ -1,5 +1,5 @@
 {
-  "name": "debugger.html",
+  "name": "debugger",
   "version": "0.6.0",
   "license": "MPL-2.0",
   "repository": {
@@ -26,7 +26,7 @@
     "lint:css": "stylelint \"src/components/**/*.css\"",
     "lint:js": "eslint *.js \"src/**/*.js\" \"packages/*/src/**/*.js\" --fix",
     "lint:jsx-a11y": "eslint *.js \"src/**/*.js\" \"packages/*/src/**/*.js\" --plugin=jsx-a11y --config=.eslintrc.jsx-a11y",
-    "lint:md": "remark -u devtools-linters/markdown/preset -qf *.md src configs docs",
+    "lint:md": "remark -u devtools-linters/markdown/preset -qf *.md src",
     "mochi": "mochii --mc ./firefox --interactive --default-test-path devtools/client/debugger/new",
     "mochid": "yarn mochi -- --jsdebugger --",
     "mochir": "yarn mochi -- --repeat 10 --",

packages/devtools-components/src/tree.js

@@ -829,7 +829,6 @@ class Tree extends Component {
         if (this.treeRef.current !== document.activeElement) {
           this.treeRef.current.focus();
         }
-        return;
     }
   }
 

packages/devtools-reps/src/object-inspector/components/ObjectInspector.js

@@ -98,7 +98,6 @@ class ObjectInspector extends Component<Props> {
       if (this.props.rootsChanged) {
         this.props.rootsChanged();
       }
-      return;
     }
   }
 

packages/devtools-source-map/src/tests/helpers.js

@@ -35,7 +35,7 @@ async function setupBundleFixture(name) {
     return { content };
   });
 
-  return await getOriginalURLs(source);
+  return getOriginalURLs(source);
 }
 
 module.exports = {

src/actions/sources/select.js

@@ -93,7 +93,7 @@ export function selectSource(
 ) {
   return async ({ dispatch }: ThunkArgs) => {
     const location = createLocation({ ...options, sourceId });
-    return await dispatch(selectSpecificLocation(location));
+    return dispatch(selectSpecificLocation(location));
   };
 }
 

src/components/App.js

@@ -191,7 +191,6 @@ class App extends Component<Props, State> {
       return;
     }
     openQuickOpen();
-    return;
   };
 
   onLayoutChange = () => {

src/main.js

@@ -5,7 +5,6 @@
 // @flow
 
 import ReactDOM from "react-dom";
-
 import { onConnect } from "./client";
 import { teardownWorkers } from "./utils/bootstrap";
 import sourceQueue from "./utils/source-queue";

src/reducers/sources.js

@@ -22,13 +22,7 @@ import {
 import { originalToGeneratedId } from "devtools-source-map";
 import { prefs } from "../utils/prefs";
 
-import type {
-  Source,
-  SourceId,
-  SourceLocation,
-  ThreadId,
-  WorkerList
-} from "../types";
+import type { Source, SourceId, SourceLocation, ThreadId } from "../types";
 import type { PendingSelectedLocation, Selector } from "./types";
 import type { Action, DonePromiseAction, FocusItem } from "../actions/types";
 import type { LoadSourceAction } from "../actions/types/SourceAction";

src/selectors/getCallStackFrames.js

@@ -63,6 +63,7 @@ export function formatCallStackFrames(
   return annotateFrames(formattedFrames);
 }
 
+// eslint-disable-next-line
 export const getCallStackFrames: State => Frame[] = (createSelector: any)(
   getFrames,
   getSources,

src/test/tests-setup.js

@@ -46,7 +46,7 @@ function getL10nBundle() {
   try {
     return read("../../assets/panel/debugger.properties");
   } catch (e) {
-    return read("../../../../locales/en-us/debugger.properties");
+    return read("../../../../locales/en-US/debugger.properties");
   }
 }
 

src/utils/build-query.js

@@ -42,8 +42,6 @@ function buildFlags(caseSensitive: boolean, isGlobal: boolean): ?RegExp$flags {
   if (!caseSensitive && !isGlobal) {
     return "i";
   }
-
-  return;
 }
 
 export default function buildQuery(

src/utils/path.js

@@ -14,7 +14,7 @@ export function dirname(path: string) {
 }
 
 export function isURL(str: string) {
-  return str.indexOf("://") !== -1;
+  return str.includes("://");
 }
 
 export function isAbsolute(str: string) {

src/utils/sources-tree/utils.js

@@ -64,7 +64,7 @@ export function isNotJavaScript(source: Source): boolean {
 
 export function isInvalidUrl(url: Object, source: Source) {
   return (
-    IGNORED_URLS.indexOf(url) != -1 ||
+    IGNORED_URLS.includes(url) ||
     !source.url ||
     !url.group ||
     isPretty(source) ||

src/utils/tests/telemetry.spec.js

@@ -27,6 +27,7 @@ describe("telemetry.recordEvent()", () => {
       "debugger",
       null,
       {
+        // eslint-disable-next-line camelcase
         session_id: -1,
         bar: 1
       }

src/workers/pretty-print/index.js

@@ -26,7 +26,7 @@ export async function prettyPrint({ source, url }: PrettyPrintOpts) {
 
   assert(isJavaScript(source), "Can't prettify non-javascript files.");
 
-  return await _prettyPrint({
+  return _prettyPrint({
     url,
     indent,
     sourceText: source.text