Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popovers in <x-buttons> don't close #136

Open
dbrnz opened this issue Oct 18, 2023 · 2 comments
Open

Popovers in <x-buttons> don't close #136

dbrnz opened this issue Oct 18, 2023 · 2 comments

Comments

@dbrnz
Copy link
Contributor

dbrnz commented Oct 18, 2023

In the following, a popover opens when the respective button is toggled on, but the popover stays open when another button is clicked (and opens its popover) even though the first button is now toggled off (tracking = 1). Is this intended?

<x-buttons tracking="1" vertical>
    <x-button id="select" skin="dock">
        <x-icon href="./icons/iconset.svg#pointer"></x-icon>
        <x-tooltip><x-message>Select</x-message></x-tooltip>
    </x-button>
    <x-button id="draw-connection" skin="dock">
        <x-icon href="./icons/iconset.svg#draw-connection"></x-icon>
        <x-tooltip><x-message>Draw connection</x-message></x-tooltip>
        <x-popover style="--align: right" id="draw-connection-popover">
            <main>
                <cd-connection-options/>
            </main>
        </x-popover>
    </x-button>
    <x-button id="add-component" skin="dock">
        <x-icon href="./icons/iconset.svg#add-component"></x-icon>
        <x-tooltip><x-message>Add component</x-message></x-tooltip>
        <x-popover style="--align: right" id="add-component-popover">
            <main>
                <cd-component-libraries/>
            </main>
        </x-popover>
    </x-button>
</x-buttons>
@jarek-foksa
Copy link
Owner

I will fix it after I finish the migration to the new Popover API (#130). The current implementation is rather convoluted and there are many edge cases where popovers are misbehaving or are misaligned.

@dbrnz
Copy link
Contributor Author

dbrnz commented Oct 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants