Tolerance for missing files #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes compiler logs to be more tolerant of missing disk artifacts. The old strategy was to simply error and bail out when artifacts were missing on disk. This was designed primarily to make sure customers weren't creating and submitting _stale_ binary logs. Diagnostics around potentially _stale_ logs are valuable but it was too agressive. It meant that the tooling couldn't represent `Compilations` with those types of errors. For example: instead of creating a `Compilation` where emit fails because of a missing key file the tooling just could not create a `Compilation` at all. This change is pushing the tooling to be tolerant of the missing artifacts while preserving the _stale_ diagnostics in `complog create`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 96.91% 96.81% -0.10%
==========================================
Files 47 47
Lines 5147 5268 +121
Branches 533 553 +20
==========================================
+ Hits 4988 5100 +112
- Misses 86 91 +5
- Partials 73 77 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes compiler logs to be more tolerant of missing disk artifacts. The old strategy was to simply error and bail out when artifacts were missing on disk. This was designed primarily to make sure customers weren't creating and submitting stale binary logs.
Diagnostics around potentially stale logs are valuable but it was too agressive. It meant that the tooling couldn't represent
Compilationswith those types of errors. For example: instead of creating aCompilationwhere emit fails because of a missing key file the tooling just could not create aCompilationat all.This change is pushing the tooling to be tolerant of the missing artifacts while preserving the stale diagnostics in
complog create.closes #217