Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: "tsdx eject" #652

Closed
helt opened this issue Mar 29, 2020 · 3 comments
Closed

Feature Request: "tsdx eject" #652

helt opened this issue Mar 29, 2020 · 3 comments
Labels
solution: duplicate This issue or pull request already exists solution: wontfix This will not be worked on

Comments

@helt
Copy link

helt commented Mar 29, 2020

I wonder if it is possible to "eject" from tsdx, similar to "react-scripts eject", i.e. remove tsdx the tsdx dependency, and materialize all config files required to have a self-sustained ts-project.

@agilgur5
Copy link
Collaborator

agilgur5 commented Mar 29, 2020

Jared previously rejected this as against the project goals in #389 (comment) and I'm not particularly for it either. He also suggested patch-package as a better alternative if absolutely necessary.

But you didn't fill out the issue template or give a use-case for it either so I can't tell if there's some escape hatch we can add or I can point to.
I also don't think ejecting for the sake of it is wise, you'll be missing out on all bugfixes & updates and will have a ton of dependencies listed too.

@agilgur5 agilgur5 added the solution: wontfix This will not be worked on label Mar 29, 2020
@agilgur5 agilgur5 changed the title Feature-request "tsdx eject" Feature Request: "tsdx eject" Mar 29, 2020
@helt
Copy link
Author

helt commented Mar 31, 2020

So, no to eject. Fine.

The main reason why I asked is that my colleagues and me like to understand whats happening under the hood of tsdx before using it in our projects.

Also, ejecting would be the final measure that would become relevant if tsdx development becomes stale while dependencies move on... That a product owner does like to keep its customers on board is just natural, but we dont like golden cages particularly well...

@agilgur5
Copy link
Collaborator

agilgur5 commented Mar 31, 2020

TSDX is an open-source project, and you're fully welcome to look under-the-hood. The meat of the codebase is probably <1k LoC.

The same is applicable if it ever becomes stale, you can fork, your team can fork, the community can fork, or (not recommended) just copy/paste portions and keep those up-to-date wherever they're used.

@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution: duplicate This issue or pull request already exists solution: wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants