FieldArray.pop doesn't remove touched on the removed field

[andersem]

🐛 Bug report

FieldArray.pop doesn't remove touched on the removed field

Current Behavior

When I remove an element from an array with FieldArray.remove, the element is unmarked as touched. If I remove the element with FieldArray.pop, it's still marked as touched.

Expected behavior

I expect FieldArray.pop to have the same side effects as FieldArray.remove

Reproducible example

https://codesandbox.io/embed/rwl80mzvwo

Suggested solution(s)

Remove touched on the element removed by pop

Additional context

Your environment

Software	Version(s)
Formik	1.5.0
React	16.8.0
TypeScript	-
Browser	Chrome 74.0
npm/Yarn	npm 6.4.1
Operating System	Windows 10

[maddhruv]

I am not able to replicate this on the codesandbox, is it that on popping the item is not removed from touched?

[andersem]

If you add an item and click outside the input, you see that it's added to touched:

{
  "values": {
    "names": [
      "first_item"
    ]
  },
  "touched": {
    "names": [
      true
    ]
  }
}

When I remove the element, the item is removed, but it's still marked as touched:

{
  "values": {
    "names": []
  },
  "touched": {
    "names": [
      true
    ]
  }
}

[thoughtspile]

Hey guys, just came here goggling to fix a similar bug in our lib. Just wanted to tell you this issue is real, and related to TouchEvents spec. Here's some info:

• Repro
• SO question
• Open issue in react
• Fixed issue in interact.js