Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razzle as dev dependency? #419

Open
topas opened this issue Jan 10, 2021 · 5 comments
Open

Razzle as dev dependency? #419

topas opened this issue Jan 10, 2021 · 5 comments

Comments

@topas
Copy link

topas commented Jan 10, 2021

🚀 Feature request

All Razzle examples use Razzle package as dev dependency. Except AfterJS - it needs Razzle as regular dependency because of razzle-dev-utils.

Current Behavior

If Razzle stays as a dev dep, I get this error message in production build:

Error: Cannot find module 'razzle-dev-utils/logger'
 Require stack:
 -  /app/node_modules/@jaredpalmer/after/build/cjs/getAssets.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/render.js
 - /app/node_modules/@jaredpalmer/after/build/cjs/index.js

Desired Behavior

I would like to add AfterJS to my Razzle based project without moving Razzle from dev to regular dependencies.

Suggested Solution

Is using razzle-dev-utils in AfterJS worth? Can it be replaced with something?

@jakub-sarnowski-blinkhealth

+1. I encountered this problem while trying to containerize a AfterJS app. Having to add razzle and all its dependencies into a production build makes the container image very big (due to all of the dependencies of razzle like babel etc.).

@stevengrimaldo
Copy link

+1. I encountered this issue as well as when testing out the examples provided it uses 1 major version behin of razzle and even no longer works once all additional dependencies are added.

@nimaa77
Copy link
Collaborator

nimaa77 commented Oct 30, 2021

your point is totally valid, I'm going to use tsdx for repo after.js package it contains necessary utils for logging ....

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
@stale stale bot closed this as completed Apr 17, 2022
@jakub-sarnowski-blinkhealth

Can we please reopen this?

@nimaa77 nimaa77 reopened this Apr 18, 2022
@stale stale bot removed the wontfix label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants