feat(explorer): make @ cycle Cluster/Monitoring dashboard from any level - #547
Merged
Merged
Conversation
The @ key previously opened the Monitoring dashboard only when the resource-type column was focused. It now backs out to the resource-types level first, so it works from the resource list or any deeper view, and cycles Cluster -> Monitoring -> Cluster (starting with Cluster).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Summary by CodeRabbit
WalkthroughThe Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the
@hotkey behaviour:@only opened the Monitoring dashboard when the resource-type column was focused. It now backs out to the resource-types level first (reusing the samenavigateParentloop the level-jump keys use), so it works from the resource list or any deeper view.Changes
internal/app/update_keys_actions.go-handleExplorerActionKeyMonitoringnavigates up to the resource-types level, then targets the Cluster dashboard unless it is already selected (then Monitoring).internal/app/update_keys_actions_test.go- 4 tests: start-with-cluster, cluster->monitoring, monitoring->cluster, and the "select a cluster first" guard.internal/ui/help_sections.go,README.md,docs/keybindings.md- help/hint text updated.Test plan
go build ./...go vet ./internal/app ./internal/uigo test ./internal/app ./internal/uigolangci-lint run(0 issues, also enforced by pre-commit hook)🤖 Generated with Claude Code