Skip to content

feat(explorer): make @ cycle Cluster/Monitoring dashboard from any level - #547

Merged
janosmiko merged 1 commit into
mainfrom
feat/monitoring-key-cycle-dashboards
Jul 20, 2026
Merged

feat(explorer): make @ cycle Cluster/Monitoring dashboard from any level#547
janosmiko merged 1 commit into
mainfrom
feat/monitoring-key-cycle-dashboards

Conversation

@janosmiko

Copy link
Copy Markdown
Owner

Summary

Reworks the @ hotkey behaviour:

  • Works from any explorer level - previously @ only opened the Monitoring dashboard when the resource-type column was focused. It now backs out to the resource-types level first (reusing the same navigateParent loop the level-jump keys use), so it works from the resource list or any deeper view.
  • Cycles Cluster / Monitoring - repeated presses toggle Cluster -> Monitoring -> Cluster, starting with the Cluster dashboard.

Changes

  • internal/app/update_keys_actions.go - handleExplorerActionKeyMonitoring navigates up to the resource-types level, then targets the Cluster dashboard unless it is already selected (then Monitoring).
  • internal/app/update_keys_actions_test.go - 4 tests: start-with-cluster, cluster->monitoring, monitoring->cluster, and the "select a cluster first" guard.
  • internal/ui/help_sections.go, README.md, docs/keybindings.md - help/hint text updated.

Test plan

  • go build ./...
  • go vet ./internal/app ./internal/ui
  • go test ./internal/app ./internal/ui
  • golangci-lint run (0 issues, also enforced by pre-commit hook)

🤖 Generated with Claude Code

The @ key previously opened the Monitoring dashboard only when the
resource-type column was focused. It now backs out to the resource-types
level first, so it works from the resource list or any deeper view, and
cycles Cluster -> Monitoring -> Cluster (starting with Cluster).
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 75fd42fe-0923-41da-8bb6-4cc4c872249f

📥 Commits

Reviewing files that changed from the base of the PR and between 56f78d5 and 206b3bf.

📒 Files selected for processing (5)
  • README.md
  • docs/keybindings.md
  • internal/app/update_keys_actions.go
  • internal/app/update_keys_actions_test.go
  • internal/ui/help_sections.go

Summary by CodeRabbit

  • New Features

    • The @ shortcut now cycles between the Cluster and Monitoring dashboards.
    • Dashboard switching works from any explorer depth.
    • A clear prompt appears when no cluster is selected.
  • Documentation

    • Updated the README, keybindings guide, and in-app help to describe the new dashboard-cycling behavior.

Walkthrough

The @ monitoring action now returns to the resource-types view and cycles between the Cluster and Monitoring dashboard entries. Tests cover initial selection, both cycling directions, and the missing-cluster error. README, keybinding documentation, and in-app help text describe the updated behavior.

Suggested reviewers: sp71

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: making @ cycle the Cluster/Monitoring dashboard from any explorer level.
Description check ✅ Passed The description covers the summary, key changes, and test plan, though several template sections like type of change and related issue are omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janosmiko
janosmiko enabled auto-merge (squash) July 20, 2026 06:05
@janosmiko
janosmiko merged commit 43ad7a3 into main Jul 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant