Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: {{<parent}} blocks #825

Open
JoshuaWise opened this issue Nov 6, 2023 · 4 comments
Open

Feature request: {{<parent}} blocks #825

JoshuaWise opened this issue Nov 6, 2023 · 4 comments

Comments

@JoshuaWise
Copy link

The official mustache website describes {{<parent}}{{/parent}} blocks, which are basically partials, except they can contain overridable {{$block}}{{/block}} sections. As far as I can tell, this feature is missing from this package.

Reference: https://mustache.github.io/mustache.5.html#Parents

@bobthecow
Copy link

"blocks" (e.g. {{$foo}}{{/foo}}) and "parents" (e.g. {{<bar}}{{/bar}}) are part of the optional "template inheritance" spec. Many Mustache implementations don't currently implement this, as it's a more recent addition to the spec.

In this case, it was added to the Mustache spec a month after the most recent release of Mustache.js.

@JoshuaWise
Copy link
Author

Ahh okay, then I guess it's not a bug. This issue can be recategorized as a feature request.

@JoshuaWise JoshuaWise changed the title Bug: {{<parent}} blocks not supported Feature request: {{<parent}} blocks Nov 9, 2023
@solidgoldpig
Copy link

There was a previous PR for this

#473

@robinmetral
Copy link

Supporting the inheritance module in mustache.js would be amazing! This is the main thing that prevents me from using mustache in more complex projects. @janl are you open to a PR?

There was a previous PR for this

#473

That one is 9 years old and looks like it should be updated to match the spec's optional inheritance module. Might be easier to start from scratch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants