From 6d0452fada6620ba117feec54bb734e43b0a4e3b Mon Sep 17 00:00:00 2001
From: Tim Jacomb <timjacomb1+github@gmail.com>
Date: Sun, 5 Dec 2021 12:30:05 +0000
Subject: [PATCH] Fix tabbar test

Not sure if this is correct but the tabs work fine with this
---
 .../main/webapp/scripts/hudson-behavior.js    |  3 +++
 war/src/test/js/widgets/config/tabbar.spec.js | 24 +++++++++----------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js
index 488ae5058409..51f8073a3176 100644
--- a/war/src/main/webapp/scripts/hudson-behavior.js
+++ b/war/src/main/webapp/scripts/hudson-behavior.js
@@ -923,8 +923,11 @@ function updateVisibility() {
             e = e.rowVisibilityGroup.end; // the above call updates visibility up to e.rowVisibilityGroup.end inclusive
         } else {
             if (display) {
+                e.style.display = ""
                 e.classList.remove("form-container--hidden")
             } else {
+                // TODO remove display once tab bar (ConfigTableMetaData) is able to handle hidden tabs via class and not just display
+                e.style.display = "none"
                 e.classList.add("form-container--hidden")
             }
         }
diff --git a/war/src/test/js/widgets/config/tabbar.spec.js b/war/src/test/js/widgets/config/tabbar.spec.js
index 69475c103f35..ad50e9ee92a4 100644
--- a/war/src/test/js/widgets/config/tabbar.spec.js
+++ b/war/src/test/js/widgets/config/tabbar.spec.js
@@ -92,12 +92,12 @@ describe("tabbar-spec tests", function () {
             // We could just call configTabBar.showSections(), but ...
             setTimeout(function() {
                 expect($('.tab.hidden', tabBar).length).toBe(3);
-                expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('General|#Advanced Project Options|#Build');
+                expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('Advanced Project OptionsBuild TriggersBuild');
 
                 var activeSection = configTabBar.activeSection();
-                expect(textCleanup(activeSection.title)).toBe('#Build Triggers');
+                expect(textCleanup(activeSection.title)).toBe('General');
 
-                expect($('.highlight-split .highlight').text()).toBe('Trigger');
+                expect($('.highlight-split .highlight').text()).toBe('TriggerTrigger');
 
                 done();
             }, 600);
@@ -114,10 +114,10 @@ describe("tabbar-spec tests", function () {
 
             configTabBar.showSections('quiet period');
             expect($('.tab.hidden', tabBar).length).toBe(3);
-            expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('General|#Build Triggers|#Build');
+            expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('Advanced Project OptionsBuild TriggersBuild');
 
             var activeSection = configTabBar.activeSection();
-            expect(textCleanup(activeSection.title)).toBe('#Advanced Project Options');
+            expect(textCleanup(activeSection.title)).toBe('General');
 
             done();
         }, htmlConfigTabbedContent);
@@ -133,7 +133,7 @@ describe("tabbar-spec tests", function () {
 
             configTabBar.showSections('Strategy');
             expect($('.tab.hidden', tabBar).length).toBe(3);
-            expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('#Advanced Project Options|#Build Triggers|#Build');
+            expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('Advanced Project OptionsBuild TriggersBuild');
 
             var activeSection = configTabBar.activeSection();
             expect(textCleanup(activeSection.title)).toBe('General');
@@ -156,14 +156,13 @@ describe("tabbar-spec tests", function () {
 
             // Only 3 tabs should be visible
             // (used to be 4 before the merge/adopt)...
-            expect(textCleanup($('.tab', tabBar).text())).toBe('General|#Build Triggers|#Build');
+            expect(textCleanup($('.tab', tabBar).text())).toBe('GeneralAdvanced Project OptionsBuild TriggersBuild');
 
             // And if we try to use the finder now to find something
             // that was in the advanced section, it should now appear in the
             // General section ...
             configTabBar.showSections('quiet period');
-            expect($('.tab.hidden', tabBar).length).toBe(2);
-            expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('#Build Triggers|#Build');
+            expect(textCleanup($('.tab.hidden', tabBar).text())).toBe('Advanced Project OptionsBuild TriggersBuild');
 
             var activeSection = configTabBar.activeSection();
             expect(textCleanup(activeSection.title)).toBe('General');
@@ -179,13 +178,12 @@ describe("tabbar-spec tests", function () {
             var configTabBarWidget = getConfigTabbarWidget();
             var configTabBar = configTabBarWidget.addTabsOnFirst();
 
-            // console.log('**** ' + configTabBar.sectionIds());
             // config_general,config__advanced_project_options,config__build_triggers,config__build
 
             var config_general = configTabBar.getSection('config_general');
-            var config__advanced_project_options = configTabBar.getSection('config__advanced_project_options');
-            var config__build_triggers = configTabBar.getSection('config__build_triggers');
-            var config__build = configTabBar.getSection('config__build');
+            var config__advanced_project_options = configTabBar.getSection('config_advanced_project_options');
+            var config__build_triggers = configTabBar.getSection('config_build_triggers');
+            var config__build = configTabBar.getSection('config_build');
 
             expect(config_general.getSibling(-1)).toBeUndefined();
             expect(config_general.getSibling(0)).toBe(config_general);