Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Return key executes finalAction during countdown #93

Open
fraserhess opened this issue Feb 26, 2025 · 2 comments
Open

FR: Return key executes finalAction during countdown #93

fraserhess opened this issue Feb 26, 2025 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@fraserhess
Copy link

I'd like to be able to hit the Return key to execute the finalAction during finalCountdown. Hopefully it's not too much hassle to add a key binding for this.

@scriptingosx scriptingosx added the enhancement New feature or request label Feb 27, 2025
@scriptingosx
Copy link
Collaborator

It was an oversight that we haven't done this yet. Thanks for pointing it out. Implementing this is easy. It will be in the next build.

However...

There is a weird thing where Setup Manager does not gain keyboard focus when launched after enrollment. You can tell this because the progress bar stays grey, rather than taking on the accentColor. When you click in the Setup Manager window, the progress bar takes on the accent color and keyboard shortcuts work (there are more, the i key open 'About this Mac…', h opens the help menu, space bar will show a scannable bar code with the serial number)

But you have to click in the window once before the keyboard focus moves to Setup Manager.

I have tried a bunch of things, but the context here over Setup Assistant is unusual and the usual commands don't seem to work.

So, even once you have the build with the proper key assignment, you will still have to click at least once... sorry.

@fraserhess
Copy link
Author

fraserhess commented Feb 27, 2025

I am familiar with these focus issues from working on the swiftDialog code to have it run at login window. And to be honest, even the policy banner feature in macOS doesn’t always get it right.

That said, it shouldn’t be an issue for anyone who already has to click around for user entry.

@scriptingosx scriptingosx added this to the v1.2 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants