Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users when part of a URL matches an organization whose employees are on strike #55

Open
jamespizzurro opened this issue Dec 6, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jamespizzurro
Copy link
Owner

jamespizzurro commented Dec 6, 2021

This feature request comes from a DM on Reddit, where a user noted that only notifying them when they visit a site like kelloggs.com that employees at Kellogg's are on strike isn't very useful because they're not going to find themselves on that site very often, and that reading the URL of the page for keywords (like "kellogg") might be more useful to, for example, notify a user about the Kellogg's strike if they're about to purchase a Kellogg's product from an online retailer.

I can definitely see in situations where the organization isn't so direct-to-consumer, e.g. wirecutter.com, why this might be more useful in getting the word out more about any strikes that are going on. The primary risk I see in implementing this is that we might generate some false positives, where we think we've found a URL that's relevant to a given strike but it actually isn't, which might encourage folks to stop using the browser extension all together if they're hit with spammy notifications too many times. To that end, we may want to consider explicitly whitelisting which domain names trigger these new class of notifications, e.g. only when you're on amazon.com, target.com, etc.; if we don't do this, we risk popping up a notification on news sites that mention Kellogg's. There are apparently even services that could potentially be used to generate this list statically or in real time, e.g. this one.

I tentatively agree that this feature is worth adding as part of a future major release so long as we're careful in implementing it properly. Note that implementation would probably require adding more attributes to each strike in data/strikes.json, e.g. a separate array of regular expressions that represent keywords to match on.

@jamespizzurro jamespizzurro added the enhancement New feature or request label Dec 6, 2021
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@jamespizzurro
Copy link
Owner Author

(I don't think we should automatically be labeling enhancement issues as stale, so I've disabled this in commit 6315455.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant