Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in ovpn file not ignored #212

Closed
meldafert opened this issue Mar 20, 2023 · 1 comment · Fixed by #213
Closed

Comments in ovpn file not ignored #212

meldafert opened this issue Mar 20, 2023 · 1 comment · Fixed by #213

Comments

@meldafert
Copy link
Contributor

When using custom openvpn configuration files, vopono does not ignore commented out configuration (using either # or ;).
Eg. given the file:

;proto tcp
proto udp
;remote my-old-server 1194
remote my-new-server 1196

vopono reports:

Found remotes: [Remote { host: Hostname("my-old-server"), port: 1194, protocol: TCP }, Remote { host: Hostname("my-new-server"), port: 1196, protocol: TCP }]

This can be worked around by removing the commented out lines from the configuration file.
However, especially when working with custom files provided by someone else, it would be better if commented out lines were ignored.

@jamesmcm
Copy link
Owner

jamesmcm commented May 5, 2023

Fixed in 0.10.6 release - https://github.com/jamesmcm/vopono/releases/tag/0.10.6 - thanks for the PR!

@jamesmcm jamesmcm closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants