From 8ee20bd36acaeb36996a09ba9d0f9e7059bb49df Mon Sep 17 00:00:00 2001 From: Richard Shiue <71320345+richardshiue@users.noreply.github.com> Date: Mon, 5 Feb 2024 22:46:47 +0800 Subject: [PATCH] fix: adapt scrollable.dart to upstream SemanticsNode changes This PR https://github.com/flutter/flutter/pull/137304 makes SemanticsNode.isMergedIntoParent readonly, which makes the customized scrollable.dart incompatible. --- sheet/lib/src/scrollable.dart | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sheet/lib/src/scrollable.dart b/sheet/lib/src/scrollable.dart index 253f8fb3..c90f2daf 100644 --- a/sheet/lib/src/scrollable.dart +++ b/sheet/lib/src/scrollable.dart @@ -866,10 +866,7 @@ class _RenderScrollSemantics extends RenderProxyBox { return; } - _innerNode ??= SemanticsNode(showOnScreen: showOnScreen); - _innerNode! - ..isMergedIntoParent = node.isPartOfNodeMerging - ..rect = node.rect; + (_innerNode ??= SemanticsNode(showOnScreen: showOnScreen)).rect = node.rect; int? firstVisibleIndex; final List excluded = [_innerNode!];