Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash Screen improvements #90

Open
jakubg1 opened this issue Jan 7, 2023 · 3 comments
Open

Crash Screen improvements #90

jakubg1 opened this issue Jan 7, 2023 · 3 comments
Labels
D: Change/Suggestion A change to an existing feature. D: Feature Request A feature that may be implemented in a future version.

Comments

@jakubg1
Copy link
Owner

jakubg1 commented Jan 7, 2023

  • Wrap words so the message is not falling out of horizontal bounds.
  • Make ellipsis appear in such a way to always fill the whole window.
  • Cut off illegal UTF-8 sequences instead of not drawing the error message.
  • Remove ellipsis from the console.
  • Add the crash message to the log and save it one last time.
  • If the Crash Screen crashes, make a fallback message or something like that.
@jakubg1 jakubg1 added D: Feature Request A feature that may be implemented in a future version. D: Change/Suggestion A change to an existing feature. labels Jan 7, 2023
@ShamblesSM
Copy link
Contributor

ResourceManager failed to load sprite messages should also include the other error that crashed the game in the first place (e.g. invalid JSON, nonexistent file, etc).

@jakubg1
Copy link
Owner Author

jakubg1 commented Jan 24, 2023

Good idea, I'll do that.

@ShamblesSM
Copy link
Contributor

Created a PR that clarifies ResourceManager-related crashes on startup. (#93)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D: Change/Suggestion A change to an existing feature. D: Feature Request A feature that may be implemented in a future version.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakubg1 @ShamblesSM