Require JDK 21 for the build and misc pom cleanups/updates #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

marko-bekhta merged 9 commits into jakartaee:main from marko-bekhta:feat/i268-jdk-21

Jul 11, 2025

Contributor

marko-bekhta commented Jun 24, 2025

fixes #268

adds more specific version maven/JDK version requirements enforced by the maven enforcer plugin
requires JDK 21 for the build
uses 17 as the release version
updates GH action build to include JDK 24
cleans up various deprecations/warnings that the build currently produces
includes the maven wrapper so that the minimum required maven version is simpler to achieve
rely more on properties in the pom file (e.g. use it to have a single place to define Java version, or plugin/dependency versions).

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/valueextraction/ValueExtractorDefinitionException.java Outdated Show resolved Hide resolved

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/ValidationException.java Outdated Show resolved Hide resolved

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/UnexpectedTypeException.java Outdated Show resolved Hide resolved

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/NoProviderFoundException.java Outdated Show resolved Hide resolved

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/ConstraintViolationException.java Outdated Show resolved Hide resolved

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/ConstraintDefinitionException.java Outdated Show resolved Hide resolved

pzygielo reviewed

View reviewed changes

src/main/java/jakarta/validation/ConstraintDeclarationException.java Outdated Show resolved Hide resolved

marko-bekhta force-pushed the feat/i268-jdk-21 branch from b0ec541 to 059a6e9 Compare

June 24, 2025 12:09

marko-bekhta requested a review from DavideD

July 8, 2025 14:50

DavideD approved these changes

View reviewed changes

Contributor

DavideD left a comment

LGTM

marko-bekhta added 9 commits

July 11, 2025 16:31


          [jakartaee#268] Set release version to 17

24251f6


          [jakartaee#268] Make Validation final and hide the constructor

8104ae9


          [jakartaee#268] Address various compilation warnings

a1c25fe


          [jakartaee#268] Update readme with new build requirements

b5440b5


          [jakartaee#268] Generate and include the maven wrapper

d48bfd4


          [jakartaee#268] Group all maven plugin versions and use properties fo…

a069452

…r them


          [jakartaee#268] Update builds to run with JDK 21/24

47a0546


          [jakartaee#268] Add enforcer plugin for JDK/Maven min versions

6b59a9c


          [jakartaee#268] Account for building with different JDKs

108e3a1

marko-bekhta force-pushed the feat/i268-jdk-21 branch from 059a6e9 to 108e3a1 Compare

July 11, 2025 14:32

marko-bekhta merged commit 66d3673 into jakartaee:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet