Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta Security 1.0 apidocs #43

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Jakarta Security 1.0 apidocs #43

merged 3 commits into from
Sep 9, 2019

Conversation

arjantijms
Copy link
Contributor

Signed-off-by: arjantijms [email protected]

  • Specification JavaDoc in the wombat/x.y/apidocs directory.

@arjantijms arjantijms mentioned this pull request Jul 22, 2019
Closed
6 tasks
@dblevins dblevins added the draft Work in Progress label Jul 24, 2019
@ivargrimstad ivargrimstad self-requested a review August 8, 2019 13:07
ivargrimstad
ivargrimstad requested changes Aug 9, 2019
View reviewed changes
Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EFSL must be included. A suggestion is to put it either under apidocs/doc-files/speclicense.html or apidocs/doc-files/EFSL.html and link to it from the footer.

@bshannon
Copy link
Contributor

The apidocs look good, marking this final.

@bshannon bshannon added final Ready for Vote and removed draft Work in Progress labels Aug 22, 2019
@waynebeaton waynebeaton added the ballot Delivered to the Specification Committee for ballot label Aug 24, 2019
@dblevins dblevins marked this pull request as ready for review September 5, 2019 23:44
@waynebeaton waynebeaton added the approved The ballot was approved by the Specification Committee label Sep 6, 2019
@dblevins dblevins merged commit 19c9496 into jakartaee:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoantoniobferreira marcoantoniobferreira marcoantoniobferreira left review comments

@bshannon bshannon bshannon left review comments

@keilw keilw keilw left review comments

@ivargrimstad ivargrimstad ivargrimstad requested changes

Assignees
No one assigned
Labels
approved The ballot was approved by the Specification Committee ballot Delivered to the Specification Committee for ballot final Ready for Vote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arjantijms @bshannon @keilw @ivargrimstad @marcoantoniobferreira @dblevins @waynebeaton