Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK Challenge ManagedThreadFactory tests, context save #226

Closed
aubi opened this issue May 20, 2022 · 1 comment
Closed

TCK Challenge ManagedThreadFactory tests, context save #226

aubi opened this issue May 20, 2022 · 1 comment
Labels
accepted Accepted certification request challenge TCK challenge
Milestone

Comments

@aubi
Copy link
Contributor

aubi commented May 20, 2022

Specification:

Jakarta Concurrency 3.0.0

Challenged test(s):

ee.jakarta.tck.concurrent.spec.ManagedThreadFactory.resourcedef.ManagedThreadFactoryDefinitionTests#testManagedThreadFactoryDefinitionAllAttributes

ee.jakarta.tck.concurrent.spec.ManagedThreadFactory.resourcedef.ManagedThreadFactoryDefinitionTests#testManagedThreadFactoryDefinitionAllAttributesEJB

ee.jakarta.tck.concurrent.spec.ManagedThreadFactory.resourcedef.ManagedThreadFactoryDefinitionTests#testParallelStreamBackedByManagedThreadFactory

ee.jakarta.tck.concurrent.spec.ManagedThreadFactory.resourcedef.ManagedThreadFactoryDefinitionTests#testParallelStreamBackedByManagedThreadFactoryEJB

ee.jakarta.tck.concurrent.spec.Platform.dd.DeploymentDescriptorTests#testDeploymentDescriptorDefinesManagedThreadFactory

TCK version:

3.0.0

Tested implementation:

Payara 6 (PR) with Concurrent-RI 3.0.0-RC1

Description

All the tests expect, that the context save happens at the moment of JNDI lookup (witch causes a creation of such ManagedThreadFactory in some implementations). The referential implementation always did the save in newThread(), as well as WildFly for example (https://www.eclipse.org/lists/cu-dev/msg00283.html).

I suggest to remove this requirement and modify the test to store the values before lookup, remove setting between lookup and newThread().
The exact behavior should be agreed and clarified, preferably in 3.1.

PR for the first 4 methods is here: #212

@smillidge
Copy link
Contributor

I've accepted the challenge and will disable the test in the 3.0.1 service release of the TCK

@smillidge smillidge added accepted Accepted certification request appealed-challenge TCK challenge was appealed and removed accepted Accepted certification request appealed-challenge TCK challenge was appealed labels Jun 27, 2022
@smillidge smillidge added this to the 3.0.1 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Accepted certification request challenge TCK challenge
Projects
None yet
Development

No branches or pull requests

3 participants