-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: rename jaeger-standalone to jaeger-all-in-one #932
Comments
let's keep releasing |
everyone should be using versioned releases, so if we rename it in 1.7 it's not going to break anyone unless people explicitly upgrade. |
Specifically, we're talking about renaming the binary, which you can ONLY download from a concrete version (unlike Docker images where we, mistakenly, published tag "1") |
Funny, I thought about opening an issue some time ago about this, but in the other direction: instead of "all-in-one", standardizing on "standalone". |
I think picking one name is more important than which name, but I think all-in-one is a bit more accurate and, more importantly, backwards compatible - there are many blog posts that refer to it already. |
For the record, I have nothing against |
👍 |
The docker image is labeled
all-in-one
but we call the executablejaeger-standalone
and that's how it is included in the binary distributions. I propose we change the executable to be called all-in-one as well.We can probably even rename the source directory to
cmd/all-in-one
, since the package name there ismain
anyway.The text was updated successfully, but these errors were encountered: