Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search returns results in different order every time #892

Closed
jpkrohling opened this issue Jun 28, 2018 · 9 comments
Closed

Search returns results in different order every time #892

jpkrohling opened this issue Jun 28, 2018 · 9 comments

Comments

@jpkrohling
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

Problem - what in Jaeger blocks you from solving the requirement?

  • The results ordering seem odd: items that are present when doing the search a first time are not present on the first page of results on a subsequent page load.
@knrt10
Copy link

knrt10 commented Sep 1, 2018

@jpkrohling I would like to work on this issue. I am new to go, would you please guide me to which files should I look into. It would be really helpful 😅.

@yurishkuro
Copy link
Member

I am not clear what this issue is about, it needs more details. It sounds closely related to #166, which is unlikely a "good first issue".

@yurishkuro
Copy link
Member

@knrt10 I would recommend picking another ticket among those labeled good first issue.

@yurishkuro yurishkuro removed good first issue Good for beginners bug labels Sep 1, 2018
@knrt10
Copy link

knrt10 commented Sep 1, 2018

Ok thanks let me try.

@jpkrohling
Copy link
Contributor Author

jpkrohling commented Sep 3, 2018

@yurishkuro this issue is only about adding a sort clause to the query used by the UI endpoint to list the traces. The in-memory might not be affected, but it would be good to make sure both the Cassandra and ES plugins have such clause in place.

As I understand, #166 is about traces that won't "ever" appear in the search results. This here is about the search results being different at each refresh. Trace "123" might show up the first time the search is executed, but then not show up when the page is reloaded, showing up again on a third reload.

@yurishkuro
Copy link
Member

the fundamental issue with Cassandra search may cause different order as well. The UI already has a Sort control, so if that's not helping then the issue is with the backend storage returning non-stable results, and I think it's mostly the problem in #166.

@m1o1
Copy link

m1o1 commented Jan 3, 2019

We've seen this with the all-in-one version of Jaeger (agents deployed as a DaemonSet) when the number of total traces is larger than the number of desired traces to return.

@mingshun
Copy link

mingshun commented Jul 5, 2023

I've seen this with ES as the backend storage on Jaeger 1.40.0. Is there any update for this issue?

@yurishkuro
Copy link
Member

yurishkuro commented Feb 3, 2024

We do not make stable results order a requirement for backend storages, not should we imo, given that this is observability data, not systems of record, and the trade-offs are made in favor of recency and availability, not consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants