Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lint fails with many 'is in the blacklist' #3741

Closed
esnible opened this issue Jun 8, 2022 · 5 comments
Closed

make lint fails with many 'is in the blacklist' #3741

esnible opened this issue Jun 8, 2022 · 5 comments
Labels

Comments

@esnible
Copy link
Contributor

esnible commented Jun 8, 2022

make lint fails with

cmd/flags/service.go:31:2: `github.com/jaegertracing/jaeger/pkg/metrics` is in the blacklist (depguard)
	pMetrics "github.com/jaegertracing/jaeger/pkg/metrics"
	^

... followed by many similar errors.

This has been happening on my Mac since #3736

(I don't see anything in that PR that would cause the problem.)

To reproduce, make lint.
It goes away if I do git checkout 060ddb75da54b490f7b9926ca63a044e0e32745f and then make lint

@esnible esnible added the bug label Jun 8, 2022
@yurishkuro
Copy link
Member

did you try to refresh the linters with make install-tools?

@esnible
Copy link
Contributor Author

esnible commented Jun 9, 2022

I still see the errors.

I am uncertain if I did the make install-tools properly because doing that step generates 21 warnings similar to

ld: warning: object file (/var/folders/4h/rp30s45n3qj6crrk111qn3ww0000gn/T/go-link-3999432636/000000.o) 
was built for newer macOS version (12.0) than being linked (11.1)

I am using macOS "Monterey" 12.4

@pavolloffay
Copy link
Member

I am uncertain if I did the make install-tools properly because doing that step generates 21 warnings similar to

One way to find out is to remove the linter and see if it will get installed.

@albertteoh
Copy link
Contributor

@esnible I wasn't able to reproduce this issue. I'm also using MacOS "Monterey" 12.4.

From this discussion: golang/go#43856 (comment), it seems it might relate to a brew-installed go and that re-installing CommandLineTools might help.

@esnible
Copy link
Contributor Author

esnible commented Jul 20, 2022

Closing because I can no longer reproduce. I am not sure if this is because of something I did, such as changing Go version, or something that changed in Jaeger.

@esnible esnible closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants