Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon returns 500 #3563

Closed
forestsword opened this issue Mar 4, 2022 · 2 comments · Fixed by #3569
Closed

Favicon returns 500 #3563

forestsword opened this issue Mar 4, 2022 · 2 comments · Fixed by #3569
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@forestsword
Copy link

forestsword commented Mar 4, 2022

Describe the bug

Looks like after the change #3399 the favicon can no longer be served. It's now an embedded gzipped file. All the versions since 1.28 return a 500, seeker can't seek error.

It can be fixed by simply removing favoriteIcon from StaticRootFiles

staticRootFiles = []string{favoriteIcon}

To Reproduce
Steps to reproduce the behavior:

  1. Run the all-in-one after 1.28 (also affects query)
  2. Open the UI in a browser

Expected behavior
Return the favicon with a 200 result.

Screenshots

2022-03-04_13-35

Version (please complete the following information):

All versions after 1.28

@forestsword forestsword added the bug label Mar 4, 2022
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Mar 4, 2022
@yurishkuro
Copy link
Member

cc @Ashmita152

@yurishkuro
Copy link
Member

curiously enough, if I run all-in-one from source, favicon is returned normally, but when I run the docker command it returns 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants