Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotrod in release and push all tags #2812

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

Ashmita152
Copy link
Contributor

@Ashmita152 Ashmita152 commented Feb 12, 2021

Signed-off-by: Ashmita Bohara [email protected]

Which problem is this PR solving?

Closes #2810

Short description of the changes

  • We were running older version of docker in travis which used to push all tags of an image on doing docker push image.
    Newer version of docker needs --all-tags flag for achieving that.
  • Added the missing hotrod build as part of release process.
  • Removed scripts used in travis and no longer used.
  • Removed all travis references.

@Ashmita152 Ashmita152 requested a review from a team as a code owner February 12, 2021 13:28
@mergify mergify bot requested a review from jpkrohling February 12, 2021 13:28
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #2812 (447e6c0) into master (c8b8168) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2812      +/-   ##
==========================================
- Coverage   95.96%   95.95%   -0.02%     
==========================================
  Files         218      218              
  Lines        9620     9620              
==========================================
- Hits         9232     9231       -1     
- Misses        321      322       +1     
  Partials       67       67              
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b8168...387ade5. Read the comment docs.

@@ -33,7 +33,7 @@ jobs:
run: make install-ci

- name: Build, test, and publish all-in-one image
run: bash scripts/travis/build-all-in-one-image.sh
run: bash scripts/build-all-in-one-image.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that rename! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Process Broken in GHA
3 participants