Remove deprecated collector flags

[LostLaser]

Signed-off-by: Jacob Goldsworthy [email protected]

Which problem is this PR solving?

• Resolves part of Remove deprecated CLI flags #2738

Short description of the changes

• Removed the deprecated collectorHTTPPort flag and the associated warning flag collectorHTTPPortWarning
• Separated the hostPort formatting from GetAddressFromCLIOptions into its' own function called FormatHostPort
• Wrapped retrieval of the CollectorHTTPHostPort property with a call to FormatHostPort
• Added tests for the FormatHostPort function

[codecov]

Codecov Report

Merging #2751 (b97b675) into master (5c4fe1f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2751   +/-   ##
=======================================
  Coverage   95.82%   95.83%           
=======================================
  Files         217      217           
  Lines        9656     9654    -2     
=======================================
- Hits         9253     9252    -1     
+ Misses        332      331    -1     
  Partials       71       71           

Impacted Files	Coverage Δ
cmd/collector/app/builder_flags.go	100.00% <100.00%> (ø)
ports/ports.go	100.00% <100.00%> (ø)
cmd/query/app/server.go	95.68% <0.00%> (-1.44%)	⬇️
cmd/query/app/static_handler.go	96.77% <0.00%> (+1.61%)	⬆️
cmd/collector/app/server/zipkin.go	76.92% <0.00%> (+3.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165ac36...bc2993f. Read the comment docs.

[yurishkuro]

editing description - this does not resolve #2738, only part of it

[yurishkuro]

please add a "breaking change" entry to the CHANGELOG

[yurishkuro]

@LostLaser thank you!