You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The spanstore.Writer interface does not propagate context.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Add a new WriteSpanWithContext(ctx context.Context, span *model.Span) error to propagate context.
Alternatively, we may update to WriteSpan(ctx context.Context, *model.Span) error.
Unfortunately, both of these are breaking changes. Alternatively, we may create a WriterV2 interface, and supply a converter from Writer to WriterV2. Such a converter would simply use ctx.Background() for the context parameter.
The text was updated successfully, but these errors were encountered:
I would vote for simply changing the signature to WriteSpan(ctx context.Context, *model.Span) error. We did the same for the Reader interface in #1038.
Problem - what in Jaeger blocks you from solving the requirement?
jaeger/storage/spanstore/interface.go
Lines 27 to 29 in 009b7f5
The
spanstore.Writer
interface does not propagate context.Proposal - what do you suggest to solve the problem or improve the existing situation?
Add a new
WriteSpanWithContext(ctx context.Context, span *model.Span) error
to propagate context.Alternatively, we may update to
WriteSpan(ctx context.Context, *model.Span) error
.Unfortunately, both of these are breaking changes. Alternatively, we may create a
WriterV2
interface, and supply a converter fromWriter
toWriterV2
. Such a converter would simply usectx.Background()
for the context parameter.The text was updated successfully, but these errors were encountered: