Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default per-operation sampling strategies #1748

Closed
rutgerbrf opened this issue Aug 20, 2019 · 0 comments · Fixed by #1749
Closed

Allow default per-operation sampling strategies #1748

rutgerbrf opened this issue Aug 20, 2019 · 0 comments · Fixed by #1749

Comments

@rutgerbrf
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

The /health and /metrics endpoint make other traces hard to find.

Problem - what in Jaeger blocks you from solving the requirement?

These traces can be ignored with the fix of #814. This fix allows to set operation strategies on a per-service basis, but with a lot of services it can quickly become unmaintainable to disable spans for the health endpoint for every service.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Allow to specify operation strategies in the default sampling strategy, like so:

{
  "default_strategy": {
    "type": "probabilistic",
    "param": 1,
    "operation_strategies": [
      {
        "operation": "op1",
        "type": "probabilistic",
        "param": 0.2
      },
      {
        "operation": "op2",
        "type": "probabilistic",
        "param": 0.4
      }
    ]
  }
}

Any open questions to address

None

Note: this issue is also very closely related to #1387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant