Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with upgrading gogo/protobuf (lots of XXX_ fields/methods) #1262

Open
yurishkuro opened this issue Dec 23, 2018 · 0 comments
Open

Issues with upgrading gogo/protobuf (lots of XXX_ fields/methods) #1262

yurishkuro opened this issue Dec 23, 2018 · 0 comments

Comments

@yurishkuro
Copy link
Member

trying out an upgrade:

diff --git a/Gopkg.toml b/Gopkg.toml
index 3073437..25bf653 100644
--- a/Gopkg.toml
+++ b/Gopkg.toml
@@ -109,11 +109,11 @@ required = [

 [[constraint]]
   name = "github.com/gogo/googleapis"
-  revision = "b23578765ee54ff6bceff57f397d833bf4ca6869"
+  version = "1.1.0"

 [[constraint]]
   name = "github.com/gogo/protobuf"
-  revision = "fd9a4790f3963525fb889cc00e0a8f828e0b3a29"
+  version = "1.2.0"

The model code gets generated with lots of unpleasant XXX_ fields and methods, e.g. KeyValue gets these:

+       XXX_NoUnkeyedLiteral struct{}  `json:"-"`
+       XXX_unrecognized     []byte    `json:"-"`
+       XXX_sizecache        int32     `json:"-"`

According to gogo issues, it's an upstream change (golang/protobuf#276).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant