-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a rate limiter to jaeger-ingester #1100
Comments
Default could be no rate limiting (backwards-compatible). |
OK never mind. Seems to affect reader, not writer. |
So should we revisit my crossed out comment above:
|
Requirement - what kind of business use case are you trying to solve?
Limit the rate of writes to the storage backend when using jaeger-ingester.
When there is a failure of the storage backed, the ingester can consume and write to the backing store at rates higher than the backing store can handle, resulting in a failure in storage nodes, leading to more chaos. We've seen this happen with Cassandra, and is probably an issue with any storage engine that doesn't gracefully degrade.
Problem - what in Jaeger blocks you from solving the requirement?
none
Proposal - what do you suggest to solve the problem or improve the existing situation?
Adding a configurable rate limiter to the Kafka reader will enable operators to set a safe throughput target.
Any open questions to address
What would be a sensible default value?
The text was updated successfully, but these errors were encountered: