Skip to content

Commit 6e04d9d

Browse files
authored
Jaeger agent logs "0" whenever sampling strategies are requested (#2382)
Fixes #2356 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
1 parent 4343528 commit 6e04d9d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

Diff for: model/converter/thrift/jaeger/sampling_from_domain.go

-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ package jaeger
1616

1717
import (
1818
"errors"
19-
"fmt"
2019
"math"
2120

2221
"github.com/jaegertracing/jaeger/proto-gen/api_v2"
@@ -67,8 +66,6 @@ func convertPerOperationFromDomain(s *api_v2.PerOperationSamplingStrategies) *sa
6766
DefaultLowerBoundTracesPerSecond: s.GetDefaultLowerBoundTracesPerSecond(),
6867
DefaultUpperBoundTracesPerSecond: &s.DefaultUpperBoundTracesPerSecond,
6968
}
70-
fmt.Println(s.GetDefaultUpperBoundTracesPerSecond())
71-
//if s.GetDefaultUpperBoundTracesPerSecond() > 0 {}
7269
if s.GetPerOperationStrategies() != nil {
7370
r.PerOperationStrategies = make([]*sampling.OperationSamplingStrategy, len(s.GetPerOperationStrategies()))
7471
for i, k := range s.PerOperationStrategies {

0 commit comments

Comments
 (0)