Skip to content

Commit 287fb43

Browse files
author
Annanay
committed
Re-evaluate fields in GRPCHandler
Signed-off-by: Annanay <[email protected]>
1 parent fc534f8 commit 287fb43

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

Diff for: cmd/query/app/grpc_handler.go

+3-9
Original file line numberDiff line numberDiff line change
@@ -35,27 +35,18 @@ type GRPCHandler struct {
3535
archiveSpanReader spanstore.Reader
3636
dependencyReader dependencystore.Reader
3737
logger *zap.Logger
38-
queryParser queryParser
39-
tracer opentracing.Tracer
4038
}
4139

4240
// NewGRPCHandler returns a GRPCHandler
4341
func NewGRPCHandler(spanReader spanstore.Reader, dependencyReader dependencystore.Reader, options ...HandlerOption) *GRPCHandler {
4442
gH := &GRPCHandler{
4543
spanReader: spanReader,
4644
dependencyReader: dependencyReader,
47-
queryParser: queryParser{
48-
traceQueryLookbackDuration: defaultTraceQueryLookbackDuration,
49-
timeNow: time.Now,
50-
},
5145
}
5246

5347
if gH.logger == nil {
5448
gH.logger = zap.NewNop()
5549
}
56-
if gH.tracer == nil {
57-
gH.tracer = opentracing.NoopTracer{}
58-
}
5950

6051
return gH
6152
}
@@ -82,6 +73,9 @@ func (g *GRPCHandler) GetTrace(ctx context.Context, r *api_v2.GetTraceRequest) (
8273
}
8374

8475
trace, err = g.archiveSpanReader.GetTrace(ctx, traceID)
76+
if err != nil {
77+
g.logger.Error("Could not fetch spans from backend", zap.Error(err))
78+
}
8579
}
8680

8781
return &api_v2.GetTraceResponse{Trace: trace}, nil

0 commit comments

Comments
 (0)