Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Move internal method contextFromString out of JaegerSpanContext #518

Closed
isaachier opened this issue Aug 17, 2018 · 0 comments
Closed

Move internal method contextFromString out of JaegerSpanContext #518

isaachier opened this issue Aug 17, 2018 · 0 comments

Comments

@isaachier
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

Currently, the internal contextFromString method resides in the JaegerSpanContext class. It produces a JaegerSpanContext instance from a string that conforms with the TextMapCodec. Arguably, this is not an ideal location for it to reside.

Problem - what in Jaeger blocks you from solving the requirement?

In the future, we would like to support other codecs, such as W3C trace identifiers (jaegertracing/jaeger#855). This method implies the only valid codec is the TextMapCodec seeing as it is the canonical method for using strings to produce JaegerSpanContext and implicitly relies on the TextMapCodec format.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Move the contextFromString method into the TextMapCodec class instead.

@isaachier isaachier changed the title Move internal method contextFromString out of JaegerSpanContext Move internal method contextFromString out of JaegerSpanContext Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant