This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 126
update hunter version to use a newer opentracing-cpp? #118
Comments
Good catch. Will update now. Thanks. |
@rnburn, while doing this, discovered that Jaeger does not implement new OpenTracing dynamic loading function. Where do I use |
Yes, in the implementation file. It was added to support building on windows. @mdouaihy updated it as part of his PR. You can see https://github.com/mdouaihy/jaeger-client-cpp/blob/9091fc42ed356cd51e640c039623279e0a4de761/src/jaegertracing/DynamicLoad.cpp |
It would be better to add the version number of corresponding opentracing-cpp with the released binary plugin library file. |
Fixed in #120. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The build-in version hunter will build with opentracing-cpp 1.4.0, and the "plugin so" will return error with other version.
The text was updated successfully, but these errors were encountered: