Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase with the latest upstream #17

Closed
jpkrohling opened this issue Sep 2, 2020 · 4 comments
Closed

Rebase with the latest upstream #17

jpkrohling opened this issue Sep 2, 2020 · 4 comments

Comments

@jpkrohling
Copy link

This repository was originally forked from TheThingsIndustries/docker-protobuf, which has included many improvements to the builder, including support for more languages and newest gRPC versions. The gRPC version bump alone would be a welcome change (see jaegertracing/jaeger#2443), as it's not simply a version change: apparently, the way the gRPC binaries are built has changed significantly.

It appears as well that C# has been supported upstream, which might be enough for us to remove our custom C# builder. Input from @Falco20019 is required here to confirm this is the case.

@jpkrohling jpkrohling self-assigned this Sep 2, 2020
@jpkrohling
Copy link
Author

Related to jaegertracing/jaeger#2449

@Falco20019
Copy link
Contributor

Right now, all but C# use 1.26.0 and we need 1.28.1 at least. Since #18 seem to intend to raise GRPC_VERSION for all to 1.31.0, we should be fine on C#!

@jpkrohling
Copy link
Author

@Falco20019 does it mean that we can remove the C#-specific parts from the build?

@Falco20019
Copy link
Contributor

@jpkrohling As long as you use 1.28.1+, you can definitely remove it. It was only necessary to build C# with at least this version and we had the requirement to not update all other versions. Once all want to use 1.31.0 anyway, we are safe again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants