New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About target mask #217

Open

KimRass opened this issue Jan 21, 2024 · 0 comments

KimRass commented Jan 21, 2024 •

edited

Loading

https://github.com/jadore801120/attention-is-all-you-need-pytorch/blob/master/transformer/Models.py#L190

I think that should be like

trg_mask = get_pad_mask(trg_seq, self.trg_pad_idx) | get_subsequent_mask(trg_seq)

am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment