Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Productize sigma.js/node-rapids extra-large-graphs to sigma.js quality and satisfaction. #1258

Closed
10 tasks done
thomcom opened this issue Jun 23, 2022 · 3 comments · May be fixed by #1252
Closed
10 tasks done

Productize sigma.js/node-rapids extra-large-graphs to sigma.js quality and satisfaction. #1258

thomcom opened this issue Jun 23, 2022 · 3 comments · May be fixed by #1252
Labels
enhancement

Comments

@thomcom
Copy link

thomcom commented Jun 23, 2022 •
edited
Loading

Complete PR and all review items.

I've produced https://www.github.com/jacomyal/sigma.js/pull/1252. Today I'm starting to revise it until there's nothing extra or unnecessary. The original PR was based on an experimental research branch that produced the fruit I was looking for. Now I want that PR to meet all of your expectations. I'm going to keep a checklist here for now, tracking my progress as I update the PR.

  • Get rid of the .glsl shaders in the demo.

I moved these shaders from the sigma.js hierarchy because I was having trouble importing them. I'll spend time making that work as expected.

  • Remove generate-graph.ts

Just gonna go with .js on this one.

  • Add arguments and messaging to generate-graph.js

  • Modify index.html to display graph parameters instead of take them.

  • Consider a button to switch between GPU and CPU data ETL with benchmark.

The above is not going to happen in this PR, it'll take another PR if we get there. I'll definitely be looking at more benchmarks if there's interest.

  • Clean up index.ts

  • Document the hacks in rapids-graph.ts and the engine improvements they imply.

  • Modify package.json to handle launching on a different port specifically for extra-large-graphs

  • Reset and minimize changes outside of extra-large-graphs.

  • Make a sweet README.md about what is going on here.

Depends on #1252
@thomcom
Copy link
Author

thomcom commented Jun 28, 2022

Finalizing the README.md now.

@thomcom thomcom mentioned this issue Jun 28, 2022
Open
@thomcom
Copy link
Author

thomcom commented Jun 28, 2022

It's done. Please take a look at https://www.github.com/jacomyal/sigma.js/pull/1252 and let me know what you think!

@Yomguithereal
Copy link
Collaborator

Thanks @thomcom, see my remarks on the PR. I will close this for now since the result is on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a GPU accelerated examples/extra-large-graphs thomcom/sigma.js
2 participants
@thomcom @Yomguithereal