Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert: Untested path encountered with double block quotes nested within double list blocks. #1142

Closed
9 tasks done
jackdewinter opened this issue Aug 4, 2024 · 1 comment

Comments

@jackdewinter
Copy link
Owner

Prerequisites

  • Are you running the latest version of this application?
  • Have you checked the Frequently Asked Questions document?
  • Have you simplified the bug report to the essential details?
    • Do you have a distinct command line to report?
    • Can you clearly state the configuration for this bug report?
    • Do you have a minimal document that highlights this bug?
    • Are any required files (configuration or Markdown document) attached to the issue?
  • Did you perform a cursory search of other issues to look for related issues?

Bug Report

Please replace any of [these areas] in the paragraphs below with the requested information.

Bug Type

  • Assertion Failure

Description

This specific test case was needed to trigger the behavior needed to test a branch that was previously thought of as unreachable.
When that branch assert was hit, it triggered.

Note that these defensive asserts are in the code to ensure that if we hit paths that we thought were unreachable, that we know about them instead of the branch failing in a bad way.

Specifics

What operating system and version are you running into this behavior on?

N/A

What version are you seeing this behavior in? (Run pip list or pipenv run pip list and look for the entry beside pymarkdownlnt.)

latest, main branch

Are there any extra steps that need to be taken before executing the application?

test_extra_044lc

What is the command line you invoke to get this behavior?

test_extra_044lc

Are you using a configuration file? Either on the command line or one of the implicit configuration files? If so, attach that file to this issue.

N/A

What Markdown document causes this behavior to manifest? Attach that file to this issue.

+ + > -----
    > > block 1
    > > block 2
    > -----
    > ```block
    > A code block
    > ```
    > -----
  + another list

Actual Behavior

This caused the branch protection assert to be triggered.

Expected Behavior

Now that we know this branch can get hit, the assert should be replaced with proper handling of the branch conditional.

@jackdewinter
Copy link
Owner Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant