Skip to content
This repository has been archived by the owner on Nov 12, 2021. It is now read-only.

visual alignment (purely aesthetic) #2

Closed
antiochp opened this issue Apr 13, 2020 · 7 comments
Closed

visual alignment (purely aesthetic) #2

antiochp opened this issue Apr 13, 2020 · 7 comments

Comments

@antiochp
Copy link

antiochp commented Apr 13, 2020

The armor prefix BEGIN SLATEPACK. is a single character too long to wrap nicely with the 15 char blocks.

BEGIN SLATEPACK. 2A4ijPMavuaBrAX EqsdWEtB5dy5ZN6 
H9md6GTf7GbsrPf c4i9i1atSdCknwQ 6nCcmJKmuUgkiu9 
KU5wFwUMYrZKXvV Z2TUVBbDwRYrS2L mA3ppP7o5EQ7yqR

BEGIN SLATEPACK SIGNED MESSAGE. fits nicely relative to a pair of 15 char blocks -

BEGIN SLATEPACK SIGNED MESSAGE. 2A4ijPMavuaBrAX 
EqsdWEtB5dy5ZN6 H9md6GTf7GbsrPf c4i9i1atSdCknwQ 
6nCcmJKmuUgkiu9 KU5wFwUMYrZKXvV Z2TUVBbDwRYrS2L

BEGIN SLATPACK. would also work but maybe a little too close to SALTPACK and looks weird...

@j01tz
Copy link
Owner

j01tz commented Apr 13, 2020

Thanks, @antiochp it would have been much nicer if the message framing was the same length as words.

One aspect worth considering is if we want to encode any more human readable data in these messages to help distinguish them. I've been considering BEGIN SLATEPACK INITIAL, BEGIN SLATEPACK RESPONSE, BEGIN SLATEPACK 1/2 (for extremely long edge case slates), BEGIN ENCRYPTED SLATEPACK. All of these could be encoded underneath the human readable armor but it might be nice to have that data visible. Do you have any thoughts on this approach? Or does it seem cleaner to leave that data as machine readable only? This is where the armoring and serialization overlap a bit.

I do think it can make sense to do some optimizing here for human readability here because a few bytes won't make a major difference and are worth an improved user experience.

@lehnberg
Copy link
Contributor

lehnberg commented Apr 13, 2020

+1 for this, I coincidentally noticed/thought about the same mis-alignment when I pasted a slate into grinnews just now!

@j01tz
Copy link
Owner

j01tz commented Apr 13, 2020

What about something like

BEGINSLATEPACK. 2xfX9bS82gxJ6jN
D6X4X843wrT84DT FkstYawTtacDqeU
MyGqBauGHxEFZNg FeEbVFsqXaKkKwK
tDvEwUBsuhb9GRf 1MK3jegnbKG5JJr
pbY4nbeZgPtRaZj QZL61Wj7iGqKBuJ
axfussSBrZq7xMQ P1rbw3GpebXkMeY
eXHDN9iascu. ENDSLATEPACK.

From my testing on mobile it looks like the words get split up into pairs to be displayed. I don't think we want to go larger than 15 character words or this gets jumbled a bit.

We also don't do any padding so the last word could be one or fifteen characters.

@j01tz j01tz mentioned this issue Apr 13, 2020
@j01tz
Copy link
Owner

j01tz commented Apr 14, 2020

I went ahead and merged #3 to try a more aligned framing based on feedback. Will keep this issue open in case we want to revisit other options here.

@antiochp
Copy link
Author

Yes. Thanks! I like this -

BEGINSLATEPACK. 2xfX9bS82gxJ6jN
D6X4X843wrT84DT FkstYawTtacDqeU
MyGqBauGHxEFZNg FeEbVFsqXaKkKwK
tDvEwUBsuhb9GRf 1MK3jegnbKG5JJr
pbY4nbeZgPtRaZj QZL61Wj7iGqKBuJ
axfussSBrZq7xMQ P1rbw3GpebXkMeY
eXHDN9iascu. ENDSLATEPACK.

@antiochp
Copy link
Author

antiochp commented Apr 14, 2020

I think we should only have a single kind of armor as well, and not a specific version for each round of communication. I suspect that will blur the purpose of this.

I'd argue the payload should effectively be opaque within the armor.

@j01tz
Copy link
Owner

j01tz commented Apr 14, 2020

I think we should only have a single kind of armor as well, and not a specific version for each round of communication.

I think this is where I am too after seeking more feedback. Going to close this now, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants