Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom icon and app name are not applied #553

Open
oldman20 opened this issue Dec 19, 2024 · 0 comments
Open

Custom icon and app name are not applied #553

oldman20 opened this issue Dec 19, 2024 · 0 comments

Comments

@oldman20
Copy link

DO NOT REPORT REVANCED STUFF IN THIS REPO
if you delete these lines and proceed to report revanced stuff like patch bugs or patch requests, you will be blocked from this repo

Use issues only to report bugs of the rvmm builder or the modules
################

[YouTube]
build-mode = "both"
excluded-patches = ""
included-patches = "'Custom header for YouTube' 'Force hide player buttons background' 'Hide Shorts dimming' 'Hide shortcuts' 'MaterialYou' 'Return YouTube Username' 'Enable slide to seek' 'Remove player controls background' 'Custom branding' 'Change header'" 
patcher-args = "-OappName=YouTube -OiconPath=mmt "
version = "auto"
apkmirror-dlurl = "https://www.apkmirror.com/apk/google-inc/youtube" # fallback
archive-dlurl = "https://archive.org/download/jhc-apks/apks/com.google.android.youtube"
arch = "arm64-v8a"

[Music]
build-mode = "both"
arch = "arm64-v8a"
apkmirror-dlurl = "https://www.apkmirror.com/apk/google-inc/youtube-music"
# archive-dlurl = "https://archive.org/download/jhc-apks/apks/com.google.android.apps.youtube.music"
included-patches = "'Custom header for YouTube Music' 'Hide overlay filter' 'Hide player overlay filter' 'Return YouTube Username' 'Permanent shuffle' 'Permanent repeat' 'Hide category bar'"

[Music-Extended]
app-name = "Music"
patches-source = "inotia00/revanced-patches"
integrations-source = "inotia00/revanced-integrations"
cli-source = "inotia00/revanced-cli"
rv-brand = "ReVanced Extended"
build-mode = "both"
arch = "arm64-v8a"
apkmirror-dlurl = "https://www.apkmirror.com/apk/google-inc/youtube-music"
# archive-dlurl = "https://archive.org/download/jhc-apks/apks/com.google.android.apps.youtube.music"
included-patches = "'Custom header for YouTube Music' 'Hide overlay filter' 'Hide player overlay filter' 'Return YouTube Username'"

[YouTube-Extended]
app-name = "YouTube"
patches-source = "inotia00/revanced-patches"
integrations-source = "inotia00/revanced-integrations"
cli-source = "inotia00/revanced-cli"
rv-brand = "ReVanced Extended"
build-mode = "both"
apkmirror-dlurl = "https://www.apkmirror.com/apk/google-inc/youtube"
archive-dlurl = "https://archive.org/download/jhc-apks/apks/com.google.android.youtube"
included-patches = "'Custom header for YouTube' 'Force hide player buttons background' 'Hide Shorts dimming' 'Hide shortcuts' 'MaterialYou' 'Return YouTube Username'"
arch = "arm64-v8a"

Above is a snippet of config.toml in my forked repo
I want to use mmt icon for YouTube, YouTube Extended, YTMusic, YTMusic Extended and the default display name in the app drawer is YouTube and YTMusic
But after building the modules and installing in kernelSU, the icon set is revancify_blue instead of mmt, the app name is YouTube ReVanced, YouTube Music, RVX Music
Furthermore, with Reddit Extended I want to name the app Reddit RVX but in the old version of your repo you can do these things via options.json, which now only uses config.toml but there is no corresponding conversion option
For example, below is the old options.json that meets my wishes

[
{
"patchName": "Custom branding icon for YouTube",
"options": [
{ 
"key": "AppIcon",
 "value": "mmt"
 }
 ]
 },
 {
 "patchName": "Custom branding name for YouTube Music",
 "options": [
 {
 "key": "AppNameNotification",
 "value": "YouTube Music Revanced Extended"
 },
 {
 "key": "AppNameLauncher",
 "value": "YTMusic"
 }
 ]
 },
 {
 "patchName": "Custom branding icon for YouTube Music",
 "options": [
 {
 "key": "AppIcon",
 "value": "mmt"
 }
 ]
 },
 {
 "patchName": "Change package name",
 "options": [
 {
 "key": "PackageNameReddit",
 "value": "com.rvx.reddit.frontpage"
 }
 ]
 },
 {
 "patchName": "Custom branding name for Reddit",
"options": [
{
"key": "AppName",
"value": "Reddit RVX"
}
]
}
]

Sincere thanks and recognition to the developer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant