From cc855d742cbc82b6ed59b0745f0a63ccc6c9ea2f Mon Sep 17 00:00:00 2001
From: Izel Nakri <contact@izelnakri.com>
Date: Sat, 18 Mar 2017 17:41:17 +0100
Subject: [PATCH] bang functions completely tested on strict mode

---
 lib/paper_trail.ex                            |   6 +-
 lib/paper_trail/version_queries.ex            |   4 +-
 .../bang_functions_simple_mode_test.exs       |   2 +-
 .../bang_functions_strict_mode_test.exs       | 341 ++++++++++++++++++
 test/paper_trail/version_queries_test.exs     |   4 +-
 5 files changed, 349 insertions(+), 8 deletions(-)

diff --git a/lib/paper_trail.ex b/lib/paper_trail.ex
index d1ff1ecb..b328b76f 100644
--- a/lib/paper_trail.ex
+++ b/lib/paper_trail.ex
@@ -40,10 +40,10 @@ defmodule PaperTrail do
   end
 
   @doc """
-  Gets the current record of a version
+  Gets the current model record/struct of a version
   """
-  def get_current(version) do
-    VersionQueries.get_current(version)
+  def get_current_model(version) do
+    VersionQueries.get_current_model(version)
   end
 
   @doc """
diff --git a/lib/paper_trail/version_queries.ex b/lib/paper_trail/version_queries.ex
index f907097c..c209b66e 100644
--- a/lib/paper_trail/version_queries.ex
+++ b/lib/paper_trail/version_queries.ex
@@ -37,9 +37,9 @@ defmodule PaperTrail.VersionQueries do
   end
 
   @doc """
-  Gets the current record of a version
+  Gets the current model record/struct of a version
   """
-  def get_current(version) do
+  def get_current_model(version) do
     @repo.get("Elixir." <> version.item_type |> String.to_existing_atom, version.item_id)
   end
 
diff --git a/test/paper_trail/bang_functions_simple_mode_test.exs b/test/paper_trail/bang_functions_simple_mode_test.exs
index 58dfe58c..ee175fd2 100644
--- a/test/paper_trail/bang_functions_simple_mode_test.exs
+++ b/test/paper_trail/bang_functions_simple_mode_test.exs
@@ -150,7 +150,7 @@ defmodule PaperTrailTest.SimpleModeBangFunctions do
   test "PaperTrail.update!/2 with an error raises Ecto.InvalidChangesetError" do
     assert_raise(Ecto.InvalidChangesetError, fn ->
       inserted_company = create_company_with_version()
-      updated_company = update_company_with_version(inserted_company, %{
+      update_company_with_version(inserted_company, %{
         name: nil, city: "Hong Kong", website: "http://www.acme.com", facebook: "acme.llc"
       })
     end)
diff --git a/test/paper_trail/bang_functions_strict_mode_test.exs b/test/paper_trail/bang_functions_strict_mode_test.exs
index 91ec1a06..e2217031 100644
--- a/test/paper_trail/bang_functions_strict_mode_test.exs
+++ b/test/paper_trail/bang_functions_strict_mode_test.exs
@@ -30,5 +30,346 @@ defmodule PaperTrailTest.StrictModeBangFunctions do
     :ok
   end
 
+  test "creating a company creates a company version with correct attributes" do
+    user = create_user()
+    inserted_company = create_company_with_version(@create_company_params, user: user)
 
+    company_count = Company.count()
+    version_count = Version.count()
+
+    company = inserted_company |> serialize()
+    version = PaperTrail.get_version(inserted_company) |> serialize()
+
+    assert company_count == 1
+    assert version_count == 1
+    assert Map.drop(company, [:id, :inserted_at, :updated_at]) == %{
+      name: "Acme LLC",
+      is_active: true,
+      city: "Greenwich",
+      website: nil,
+      address: nil,
+      facebook: nil,
+      twitter: nil,
+      founded_in: nil,
+      first_version_id: version.id,
+      current_version_id: version.id
+    }
+    assert Map.drop(version, [:id, :inserted_at]) == %{
+      event: "insert",
+      item_type: "StrictCompany",
+      item_id: company.id,
+      item_changes: convert_to_string_map(company),
+      originator_id: user.id,
+      origin: nil,
+      meta: nil
+    }
+    assert company == first(Company, :id) |> @repo.one |> serialize
+  end
+
+  test "PaperTrail.insert!/2 with an error raises Ecto.InvalidChangesetError" do
+    assert_raise(Ecto.InvalidChangesetError, fn ->
+      create_company_with_version(%{name: nil, is_active: true, city: "Greenwich"})
+    end)
+  end
+
+  test "updating a company creates a company version with correct item_changes" do
+    user = create_user()
+    inserted_company = create_company_with_version()
+    inserted_company_version = PaperTrail.get_version(inserted_company) |> serialize
+    updated_company = update_company_with_version(
+      inserted_company, @update_company_params, originator: user
+    )
+
+    company_count = Company.count()
+    version_count = Version.count()
+
+    company = updated_company |> serialize
+    updated_company_version = PaperTrail.get_version(updated_company) |> serialize
+
+    assert company_count == 1
+    assert version_count == 2
+    assert Map.drop(company, [:id, :inserted_at, :updated_at]) == %{
+      name: "Acme LLC",
+      is_active: true,
+      city: "Hong Kong",
+      website: "http://www.acme.com",
+      address: nil,
+      facebook: "acme.llc",
+      twitter: nil,
+      founded_in: nil,
+      first_version_id: inserted_company_version.id,
+      current_version_id: updated_company_version.id
+    }
+    assert Map.drop(updated_company_version, [:id, :inserted_at]) == %{
+      event: "update",
+      item_type: "StrictCompany",
+      item_id: company.id,
+      item_changes: convert_to_string_map(%{
+        city: "Hong Kong",
+        website: "http://www.acme.com",
+        facebook: "acme.llc",
+        current_version_id: updated_company_version.id
+      }),
+      originator_id: user.id,
+      origin: nil,
+      meta: nil
+    }
+    assert company == first(Company, :id) |> @repo.one |> serialize
+  end
+
+  test "PaperTrail.update!/2 with an error raises Ecto.InvalidChangesetError" do
+    assert_raise(Ecto.InvalidChangesetError, fn ->
+      inserted_company = create_company_with_version()
+      update_company_with_version(inserted_company, %{
+        name: nil, city: "Hong Kong", website: "http://www.acme.com", facebook: "acme.llc"
+      })
+    end)
+  end
+
+  test "deleting a company creates a company version with correct attributes" do
+    user = create_user()
+    inserted_company = create_company_with_version()
+    inserted_company_version = PaperTrail.get_version(inserted_company)
+    updated_company = update_company_with_version(inserted_company)
+    updated_company_version = PaperTrail.get_version(updated_company)
+    company_before_deletion = first(Company, :id) |> @repo.one |> serialize
+    deleted_company = PaperTrail.delete!(updated_company, user: user)
+
+    company_count = Company.count()
+    version_count = Version.count()
+
+    old_company = deleted_company |> serialize
+    deleted_company_version = PaperTrail.get_version(deleted_company) |> serialize
+
+    assert company_count == 0
+    assert version_count == 3
+    assert Map.drop(old_company, [:id, :inserted_at, :updated_at]) == %{
+      name: "Acme LLC",
+      is_active: true,
+      city: "Hong Kong",
+      website: "http://www.acme.com",
+      address: nil,
+      facebook: "acme.llc",
+      twitter: nil,
+      founded_in: nil,
+      first_version_id: inserted_company_version.id,
+      current_version_id: updated_company_version.id
+    }
+    assert Map.drop(deleted_company_version, [:id, :inserted_at]) == %{
+      event: "delete",
+      item_type: "StrictCompany",
+      item_id: old_company.id,
+      item_changes: convert_to_string_map(%{
+        id: old_company.id,
+        inserted_at: old_company.inserted_at,
+        updated_at: old_company.updated_at,
+        name: "Acme LLC",
+        is_active: true,
+        website: "http://www.acme.com",
+        city: "Hong Kong",
+        address: nil,
+        facebook: "acme.llc",
+        twitter: nil,
+        founded_in: nil,
+        first_version_id: inserted_company_version.id,
+        current_version_id: updated_company_version.id
+      }),
+      originator_id: user.id,
+      origin: nil,
+      meta: nil
+    }
+    assert old_company == company_before_deletion
+  end
+
+  test "PaperTrail.delete!/2 with an error raises Ecto.InvalidChangesetError" do
+    assert_raise(Ecto.InvalidChangesetError, fn ->
+      inserted_company = create_company_with_version()
+      Person.changeset(%Person{}, %{
+        first_name: "Izel",
+        last_name: "Nakri",
+        gender: true,
+        company_id: inserted_company.id
+      }) |> PaperTrail.insert!
+      inserted_company |> Company.changeset |> PaperTrail.delete!
+    end)
+  end
+
+  test "creating a person with meta tag creates a person version with correct attributes" do
+    create_company_with_version(%{name: "Acme LLC", website: "http://www.acme.com"})
+    inserted_company = create_company_with_version(%{
+      name: "Another Company Corp.",
+      is_active: true,
+      address: "Sesame street 100/3, 101010"
+    })
+    inserted_person = Person.changeset(%Person{}, %{
+      first_name: "Izel",
+      last_name: "Nakri",
+      gender: true,
+      company_id: inserted_company.id
+    }) |> PaperTrail.insert!(origin: "admin", meta: %{linkname: "izelnakri"})
+
+    person_count = Person.count()
+    version_count = Version.count()
+
+    person = inserted_person |> serialize
+    version = PaperTrail.get_version(inserted_person) |> serialize
+
+    assert person_count == 1
+    assert version_count == 3
+    assert Map.drop(person, [:id, :inserted_at, :updated_at]) == %{
+      first_name: "Izel",
+      last_name: "Nakri",
+      gender: true,
+      visit_count: nil,
+      birthdate: nil,
+      company_id: inserted_company.id,
+      first_version_id: version.id,
+      current_version_id: version.id
+    }
+    assert Map.drop(version, [:id, :inserted_at]) == %{
+      event: "insert",
+      item_type: "StrictPerson",
+      item_id: person.id,
+      item_changes: convert_to_string_map(person),
+      originator_id: nil,
+      origin: "admin",
+      meta: %{"linkname" => "izelnakri"}
+    }
+    assert person == first(Person, :id) |> @repo.one |> serialize
+  end
+
+  test "updating a person creates a person version with correct attributes" do
+    inserted_initial_company = create_company_with_version(%{
+      name: "Acme LLC", website: "http://www.acme.com"
+    })
+    inserted_target_company = create_company_with_version(%{
+      name: "Another Company Corp.", is_active: true, address: "Sesame street 100/3, 101010"
+    })
+    inserted_person = Person.changeset(%Person{}, %{
+      first_name: "Izel",
+      last_name: "Nakri",
+      gender: true,
+      company_id: inserted_target_company.id
+    }) |> PaperTrail.insert!(origin: "admin")
+    inserted_person_version = PaperTrail.get_version(inserted_person) |> serialize
+    updated_person = Person.changeset(inserted_person, %{
+      first_name: "Isaac",
+      visit_count: 10,
+      birthdate: ~D[1992-04-01],
+      company_id: inserted_initial_company.id
+    }) |> PaperTrail.update!(origin: "scraper", meta: %{linkname: "izelnakri"})
+
+    person_count = Person.count()
+    company_count = Company.count()
+    version_count = Version.count()
+
+    person = updated_person |> serialize
+    updated_person_version = PaperTrail.get_version(updated_person) |> serialize
+
+    assert person_count == 1
+    assert company_count == 2
+    assert version_count == 4
+    assert Map.drop(person, [:id, :inserted_at, :updated_at]) == %{
+      company_id: inserted_initial_company.id,
+      first_name: "Isaac",
+      visit_count: 10,
+      birthdate: elem(Ecto.Date.cast(~D[1992-04-01]), 1), #  this is the only problem
+      last_name: "Nakri",
+      gender: true,
+      first_version_id: inserted_person_version.id,
+      current_version_id: updated_person_version.id
+    }
+    assert Map.drop(updated_person_version, [:id, :inserted_at]) == %{
+      event: "update",
+      item_type: "StrictPerson",
+      item_id: person.id,
+      item_changes: convert_to_string_map(%{
+        first_name: "Isaac",
+        visit_count: 10,
+        birthdate: elem(Ecto.Date.cast(~D[1992-04-01]), 1),
+        current_version_id: updated_person_version.id,
+        company_id: inserted_initial_company.id
+      }),
+      originator_id: nil,
+      origin: "scraper",
+      meta: %{"linkname" => "izelnakri"}
+    }
+    assert person == first(Person, :id) |> @repo.one |> serialize
+  end
+
+  test "deleting a person creates a person version with correct attributes" do
+    create_company_with_version(%{name: "Acme LLC", website: "http://www.acme.com"})
+    inserted_company = create_company_with_version(%{
+      name: "Another Company Corp.", is_active: true, address: "Sesame street 100/3, 101010"
+    })
+    inserted_person = Person.changeset(%Person{}, %{
+      first_name: "Izel",
+      last_name: "Nakri",
+      gender: true,
+      company_id: inserted_company.id
+    }) |> PaperTrail.insert!(origin: "admin")
+    inserted_person_version = PaperTrail.get_version(inserted_person) |> serialize
+    updated_person = Person.changeset(inserted_person, %{
+      first_name: "Isaac",
+      visit_count: 10,
+      birthdate: ~D[1992-04-01]
+    }) |> PaperTrail.update!(origin: "scraper", meta: %{linkname: "izelnakri"})
+    updated_person_version = PaperTrail.get_version(updated_person) |> serialize
+    person_before_deletion = first(Person, :id) |> @repo.one
+    deleted_person = PaperTrail.delete!(
+      updated_person, origin: "admin", meta: %{linkname: "izelnakri"}
+    )
+    deleted_person_version = PaperTrail.get_version(deleted_person) |> serialize
+
+    person_count = Person.count()
+    company_count = Company.count()
+    version_count = Version.count()
+
+    assert person_count == 0
+    assert company_count == 2
+    assert version_count == 5
+    assert Map.drop(deleted_person_version, [:id, :inserted_at]) == %{
+      event: "delete",
+      item_type: "StrictPerson",
+      item_id: deleted_person.id,
+      item_changes: convert_to_string_map(%{
+        id: deleted_person.id,
+        inserted_at: deleted_person.inserted_at,
+        updated_at: deleted_person.updated_at,
+        first_name: "Isaac",
+        last_name: "Nakri",
+        gender: true,
+        visit_count: 10,
+        birthdate: elem(Ecto.Date.cast(~D[1992-04-01]), 1),
+        company_id: inserted_company.id,
+        first_version_id: inserted_person_version.id,
+        current_version_id: updated_person_version.id
+      }),
+      originator_id: nil,
+      origin: "admin",
+      meta: %{"linkname" => "izelnakri"}
+    }
+    assert deleted_person |> serialize == person_before_deletion |> serialize
+  end
+
+  defp create_user do
+    User.changeset(%User{}, %{token: "fake-token", username: "izelnakri"}) |> @repo.insert!
+  end
+
+  defp create_company_with_version(params \\ @create_company_params, options \\ nil) do
+    Company.changeset(%Company{}, params) |> PaperTrail.insert!(options)
+  end
+
+  defp update_company_with_version(company, params \\ @update_company_params, options \\ nil) do
+    Company.changeset(company, params) |> PaperTrail.update!(options)
+  end
+
+  defp serialize(model) do
+    relationships = model.__struct__.__schema__(:associations)
+    Map.drop(model, [:__struct__, :__meta__] ++ relationships)
+  end
+
+  def convert_to_string_map(map) do
+    map |> Poison.encode! |> Poison.decode!
+  end
 end
diff --git a/test/paper_trail/version_queries_test.exs b/test/paper_trail/version_queries_test.exs
index 5a1726fa..6a792358 100644
--- a/test/paper_trail/version_queries_test.exs
+++ b/test/paper_trail/version_queries_test.exs
@@ -83,11 +83,11 @@ defmodule PaperTrailTest.VersionQueries do
     assert PaperTrail.get_versions(Person, last_person.id) == target_versions
   end
 
-  test "get_current gives us the current record of a version" do
+  test "get_current_model/1 gives us the current record of a version" do
     person = first(Person, :id) |> @repo.one
     first_version = Version |> where([v], v.item_type == "SimplePerson" and v.item_id == ^person.id) |> first |> @repo.one
 
-    assert PaperTrail.get_current(first_version) == person
+    assert PaperTrail.get_current_model(first_version) == person
   end
   # query meta data!!
 end