Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running compatibility transforms for new d3 packages #67

Open
buschtoens opened this issue Nov 13, 2018 · 1 comment
Open

Running compatibility transforms for new d3 packages #67

buschtoens opened this issue Nov 13, 2018 · 1 comment

Comments

@buschtoens
Copy link

buschtoens commented Nov 13, 2018

d3/d3-array#80 (comment):

Yes, I’m starting to adopt more recent ES features in D3 modules. [...]

d3 is starting to use ES features, which are not natively supported in browsers like IE11. Since all packages are just run through the amd transform, this means that unsupported syntax, like arrow functions, makes it into the production build.

I guess this means, that ember-d3 should run the treeForVendor through ember-cli-babel with transforms based on the host project's targets.js?

@ivanvanderbyl
Copy link
Owner

@buschtoens thanks for letting us know. This will require some refactoring, we avoided this in the past because it added a considerable compile time cost during development. This could be overcome, just needs a PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants