Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: rename this package to ember-cli-d3-shim #22

Open
ivanvanderbyl opened this issue Jul 19, 2016 · 5 comments
Open

Proposal: rename this package to ember-cli-d3-shim #22

ivanvanderbyl opened this issue Jul 19, 2016 · 5 comments

Comments

@ivanvanderbyl
Copy link
Owner

Considering this now just wraps [email protected], I think it's time to deprecate ember-cli-d3-shape and release [email protected].

This would require notifying everyone who is using this as a dependency, which thankfully is only 4 projects

@mike-north
Copy link
Contributor

mike-north commented Jul 22, 2016

This would require notifying everyone who is using this as a dependency, which thankfully is only 4 projects

There are probably some private projects that use this :)

Also, there's also a d3-shim (https://github.com/brzpegasus/ember-d3). Do you see a compelling reason to make another library?

@ivanvanderbyl
Copy link
Owner Author

No, I'd like to either combine this with ember-d3 or ember-cli-d3, however the latter is not just a loader, it includes some helpers and components which should be part of a graphing addon.

So to help reduce confusion about what this does, I'd like to get rid of the -shape in the name :)

@mike-north
Copy link
Contributor

mike-north commented Jul 22, 2016

I'm sure @mingcodes would have no objection to using a common shim in ember-cli-d3 to actually import the library and add it to the asset pipeline. His library overlaps a bit with maximum plaid, but as you say this is the "graphing addon" layer -- not the uninteresting "import a third party library" layer.

@mrosenberg
Copy link

I'm really excited by all the advances made in charting and Ember. I like the idea of renaming this package. We are currently moving away from the ember-charts library to more customized charts and the Ember addon d3 space is confusing as to what each package actually does.

@ivanvanderbyl
Copy link
Owner Author

@mrosenberg we're working towards making the ecosystem more consistent. It looks like this library will be merged in to ember-d3 soon: ivanvanderbyl/ember-d3#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants